Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965242Ab2JDOgP (ORCPT ); Thu, 4 Oct 2012 10:36:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28436 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965038Ab2JDOgN (ORCPT ); Thu, 4 Oct 2012 10:36:13 -0400 Date: Thu, 4 Oct 2012 16:35:11 +0200 From: Alexander Gordeev To: Jeff Garzik Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Thomas Gleixner , Bjorn Helgaas , Suresh Siddha , Yinghai Lu , Matthew Wilcox , x86@kernel.org, linux-pci@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs Message-ID: <20121004143511.GE2258@dhcp-26-207.brq.redhat.com> References: <20121002050929.GD7756@gmail.com> <20121002164220.GB2258@dhcp-26-207.brq.redhat.com> <506B1A26.2060609@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506B1A26.2060609@pobox.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1097 Lines: 30 On Tue, Oct 02, 2012 at 12:45:26PM -0400, Jeff Garzik wrote: > >>>+ VPRINTK("ENTER\n"); > >> > >>Is this per IRQ handler execution debugging code still needed? > >>Same for the other VPRINTK() lines in this patch. > > > >These VPRINKs are only to make new handlers look like ahci_interrupt() > >which did not change. I believe, if they need to go it is better to > >remove them altogether, with a separate followup patch. > > Definitely followup patch material + discussion :) It appears the discussion comes first :) As DPRINTKs/VPRINTKs are all over the ATA stack, I do not really realize why it should be eliminated in one places (i.e. in hardware handlers) and left in anothers. So as long as you would not like to remove them all, I would leave it as is for now. Does it make sense for you? -- Regards, Alexander Gordeev agordeev@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/