Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965348Ab2JDOpW (ORCPT ); Thu, 4 Oct 2012 10:45:22 -0400 Received: from mail.vyatta.com ([76.74.103.46]:57609 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965008Ab2JDOpU (ORCPT ); Thu, 4 Oct 2012 10:45:20 -0400 Date: Thu, 4 Oct 2012 07:44:42 -0700 From: Stephen Hemminger To: Peter Senna Tschudin Cc: mlindner@marvell.com, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code Message-ID: <20121004074442.180d8f01@nehalam.linuxnetplumber.net> In-Reply-To: References: <1349281090-10013-20-git-send-email-peter.senna@gmail.com> <20121003092508.6a7da662@nehalam.linuxnetplumber.net> Organization: Vyatta X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 34 On Thu, 4 Oct 2012 11:05:55 +0200 Peter Senna Tschudin wrote: > > > > Thanks for looking into these kind of problems. The contents > > of the patch are correct, but the automated commit message is useless. > > You shouldn't just blindly say what the automated > > script was looking for, you should describe what the bug is so that evaluators > > can decide what the impact is and if it should be backported to stable > > and vendor kernels. > > > > Please resubmit the patchs with a reasonable analysis in the commit message. > > Something like: > > > > There is a bug in skge driver. If alloc_etherdev() fails, then > > skge_devinit() will return NULL, and the skge_probe function incorrectly > > returns success 0. It should return -ENOMEM instead. > > > > > > Stephen, I do not want to include function names on the commit > message. What do you think about this updated message, is it > acceptable? > No still to generic, it needs to be written by a human examining the file and understanding what the cause and effect of the bug is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/