Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965421Ab2JDOvG (ORCPT ); Thu, 4 Oct 2012 10:51:06 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:40921 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965130Ab2JDOvD (ORCPT ); Thu, 4 Oct 2012 10:51:03 -0400 From: Florian Fainelli To: Alan Stern Cc: linux-usb@vger.kernel.org, Ralf Baechle , Jayachandran C , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/25] MIPS: Netlogic: use ehci-platform driver Date: Thu, 04 Oct 2012 07:51:01 -0700 (PDT) Message-ID: <17094030.Jd6tWHquEF@flexo> Organization: OpenWrt User-Agent: KMail/4.8.5 (Linux/3.2.0-24-generic; KDE/4.8.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2291 Lines: 65 On Wednesday 03 October 2012 12:47:58 Alan Stern wrote: > On Wed, 3 Oct 2012, Florian Fainelli wrote: > > > Signed-off-by: Florian Fainelli > > IMO, patches should always have a non-empty changelog. Even if it is > relatively trivial. The same comment applies to several other patches > in this series. > > > --- > > arch/mips/netlogic/xlr/platform.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Does this need to enable CONFIG_USB_EHCI_HCD_PLATFORM is some > defconfig file, like you did with the MIPS Loongson 1B? Netlogic platforms have USB disabled by default in their defconfig, so I'd say no, but only for them. > > And likewise for quite a few of the other patches in this series. > > > diff --git a/arch/mips/netlogic/xlr/platform.c b/arch/mips/netlogic/xlr/platform.c > > index 71b44d8..1731dfd 100644 > > --- a/arch/mips/netlogic/xlr/platform.c > > +++ b/arch/mips/netlogic/xlr/platform.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -123,6 +124,10 @@ static u64 xls_usb_dmamask = ~(u32)0; > > }, \ > > } > > > > +static struct usb_ehci_pdata xls_usb_ehci_pdata = { > > + .caps_offset = 0, > > +}; > > + > > static struct platform_device xls_usb_ehci_device = > > USB_PLATFORM_DEV("ehci-xls", 0, PIC_USB_IRQ); > > static struct platform_device xls_usb_ohci_device_0 = > > @@ -172,6 +177,7 @@ int xls_platform_usb_init(void) > > memres = CPHYSADDR((unsigned long)usb_mmio); > > xls_usb_ehci_device.resource[0].start = memres; > > xls_usb_ehci_device.resource[0].end = memres + 0x400 - 1; > > + xls_usb_ehci_device.dev.platform_data = &xls_usb_ehci_pdata; > > > > memres += 0x400; > > xls_usb_ohci_device_0.resource[0].start = memres; > > Don't you need to change/set the pdev name also? Likewise for patch > 20/25 and 24/25. > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/