Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756240Ab2JDTTN (ORCPT ); Thu, 4 Oct 2012 15:19:13 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:45989 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755821Ab2JDTTL (ORCPT ); Thu, 4 Oct 2012 15:19:11 -0400 Date: Thu, 4 Oct 2012 15:19:10 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Florian Fainelli cc: linux-usb@vger.kernel.org, Anton Vorontsov , Russell King , , Subject: Re: [PATCH 17/24 v2] ARM: cns3xxx: use OHCI platform driver In-Reply-To: <1349363872-27004-18-git-send-email-florian@openwrt.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 21 On Thu, 4 Oct 2012, Florian Fainelli wrote: > Since both the EHCI and OHCI platform drivers use the same power_{on,off} > callbacks, rename them to cns3xx_usb_power_{on,off} to show that they are > shared. This is an example of the sort of thing I complained about before. People who read only the patch description and not the title will wonder why this patch adds cns3xxx_usb_ohci_pdata and cns3xxx_usb_ohci_device. And people who read both will wonder why they talk about different things. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/