Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754992Ab2JEJQG (ORCPT ); Fri, 5 Oct 2012 05:16:06 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:38956 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754749Ab2JEJQD (ORCPT ); Fri, 5 Oct 2012 05:16:03 -0400 Message-ID: <506EA54F.1020807@mev.co.uk> Date: Fri, 5 Oct 2012 10:15:59 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120917 Thunderbird/15.0.1 MIME-Version: 1.0 To: YAMANE Toshiaki CC: Greg Kroah-Hartman , Ian Abbott , Frank Mori Hess , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging/comedi: Use dev_ printks in drivers/adl_pci8164.c References: <1349395666-6010-1-git-send-email-yamanetoshi@gmail.com> In-Reply-To: <1349395666-6010-1-git-send-email-yamanetoshi@gmail.com> Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2063 Lines: 54 On 2012-10-05 01:07, YAMANE Toshiaki wrote: > fixed below checkpatch warning. > - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > > Signed-off-by: YAMANE Toshiaki > --- > drivers/staging/comedi/drivers/adl_pci8164.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/adl_pci8164.c b/drivers/staging/comedi/drivers/adl_pci8164.c > index 05e06e7..6dbe465 100644 > --- a/drivers/staging/comedi/drivers/adl_pci8164.c > +++ b/drivers/staging/comedi/drivers/adl_pci8164.c > @@ -89,9 +89,9 @@ static void adl_pci8164_insn_read(struct comedi_device *dev, > } > > data[0] = inw(dev->iobase + axis_reg + offset); > - printk(KERN_DEBUG "comedi: pci8164 %s read -> " > - "%04X:%04X on axis %s\n", > - action, data[0], data[1], axisname); > + dev_dbg(dev->class_dev, > + "comedi: pci8164 %s read -> %04X:%04X on axis %s\n", > + action, data[0], data[1], axisname); > } The "comedi: " prefix is superfluous, so should be removed. The dev_dbg() call will emit the word "comedi" twice already without the extra prefix. > > static int adl_pci8164_insn_read_msts(struct comedi_device *dev, > @@ -170,9 +170,9 @@ static void adl_pci8164_insn_out(struct comedi_device *dev, > > outw(data[0], dev->iobase + axis_reg + offset); > > - printk(KERN_DEBUG "comedi: pci8164 %s write -> " > - "%04X:%04X on axis %s\n", > - action, data[0], data[1], axisname); > + dev_dbg(dev->class_dev, > + "comedi: pci8164 %s write -> %04X:%04X on axis %s\n", > + action, data[0], data[1], axisname); > > } Same here. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/