Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755548Ab2JELtq (ORCPT ); Fri, 5 Oct 2012 07:49:46 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:36956 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755391Ab2JELtp (ORCPT ); Fri, 5 Oct 2012 07:49:45 -0400 MIME-Version: 1.0 In-Reply-To: <1349434879.14388.35.camel@twins> References: <1349434879.14388.35.camel@twins> Date: Fri, 5 Oct 2012 13:49:44 +0200 Message-ID: Subject: Re: [RFC] perf: perf_event_attr anon unions and static initializer issue From: Stephane Eranian To: Peter Zijlstra Cc: LKML , "mingo@elte.hu" , David Ahern , Arnaldo Carvalho de Melo , Namhyung Kim Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1057 Lines: 28 On Fri, Oct 5, 2012 at 1:01 PM, Peter Zijlstra wrote: > On Fri, 2012-10-05 at 12:36 +0200, Stephane Eranian wrote: > >> struct perf_event_attr attr = { .config = 0x1234, .config1 = 0x456 }; > >> Does anyone have a better solution to propose? > > > struct perf_event_attr attr = { > .config = 0x1234, > { .config1 = 0x5678 }, > }; > > sometimes works, but apparently not in this case.. its a bit unfortunate > indeed. EDG based compilers and the latest C std use your version -- > hence also 4.6 supporting it. > > Yeah, I'm afraid we're stuck with this until a future where modern C > isn't modern anymore. Yeah, unfortunately. I ended up creating a separate table for config1 and initializing attr.config1 at runtime. That way it works regardless of the compiler.... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/