Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756573Ab2JEPhQ (ORCPT ); Fri, 5 Oct 2012 11:37:16 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:52179 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755123Ab2JEPhK (ORCPT ); Fri, 5 Oct 2012 11:37:10 -0400 Subject: Re: kernel 3.2.27 on arm: WARNING: at mm/page_alloc.c:2109 __alloc_pages_nodemask+0x1d4/0x68c() From: Eric Dumazet To: mbizon@freebox.fr Cc: David Madore , Francois Romieu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hugh Dickins In-Reply-To: <1349450151.28867.33.camel@sakura.staff.proxad.net> References: <20120829002548.GA7063@aldebaran.gro-tsen.net> <1349366521.2532.12.camel@sakura.staff.proxad.net> <1349368171.16011.79.camel@edumazet-glaptop> <1349422868.21172.38.camel@edumazet-glaptop> <1349434194.16710.44.camel@sakura.staff.proxad.net> <1349439732.21172.52.camel@edumazet-glaptop> <1349441509.28867.17.camel@sakura.staff.proxad.net> <1349442173.21172.66.camel@edumazet-glaptop> <1349448659.28867.27.camel@sakura.staff.proxad.net> <1349449440.21172.118.camel@edumazet-glaptop> <1349450151.28867.33.camel@sakura.staff.proxad.net> Content-Type: text/plain; charset="UTF-8" Date: Fri, 05 Oct 2012 17:37:05 +0200 Message-ID: <1349451425.21172.119.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 27 On Fri, 2012-10-05 at 17:15 +0200, Maxime Bizon wrote: > You think removing skb_recycle() is too big a change for stable ? > > Driver change is simple, as recycling is not guaranteed today you have > this: > > if (!try_recycle(skb)) > skb = alloc_skb() > > > we just remove the try_recycle part, we are not adding any new code > path. > > > I'm not the right person to give you a correct NET_SKB_PAD value, I have > a lot of out of tree patches in my kernels, some custom drivers as well > that needs quite a lot of headroom, and uncommon network setup. > OK, I'll send the patch to remove skb_recycle() -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/