Date: Fri, 5 Oct 2012 13:56:45 -0400 (EDT)
From: Alan Stern <stern@rowland.harvard.edu>
To: Florian Fainelli <florian@openwrt.org>
cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/32 v2] USB: ohci: move ohci_pci_{suspend,resume} to
 ohci-hcd.c
In-Reply-To: <1349454064-11606-14-git-send-email-florian@openwrt.org>
Message-ID: <Pine.LNX.4.44L0.1210051337040.1541-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1030
Lines: 26

On Fri, 5 Oct 2012, Florian Fainelli wrote:

> As suggested by Alan Stern, move the ohci-pci.c ohci_pci_{suspend,resume}
> routines to ohci-hcd.c. Due to their move, also rename them to
> ohci_{suspend,resume} to make it clear they operate on ohci_hcd. Since they
> are not necessarily called, annotate them with __maybe_unused.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> Changes since v1:
> - moved ohci_{suspend,resume} out of the #ifdef CONFIG_PM block
> - removed the empty CONFIG_PM #ifdef/endif block in ohci-pci.c

Sorry, I didn't explain very well before.  These two routines _should_
remain within "#ifdef CONFIG_PM".

In the v1 patch you put them instead inside "#if defined(CONFIG_PM) ||
defined(CONFIG_PCI)"; that's what I didn't like.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/