Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751390Ab2JESyY (ORCPT ); Fri, 5 Oct 2012 14:54:24 -0400 Received: from mail-oa0-f46.google.com ([209.85.219.46]:52867 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709Ab2JESyW (ORCPT ); Fri, 5 Oct 2012 14:54:22 -0400 MIME-Version: 1.0 In-Reply-To: <506C0EC6.9000503@jp.fujitsu.com> References: <506C0AE8.40702@jp.fujitsu.com> <506C0EC6.9000503@jp.fujitsu.com> From: KOSAKI Motohiro Date: Fri, 5 Oct 2012 14:54:01 -0400 X-Google-Sender-Auth: 3-RARGyKoV9CIJUu7QMlbXczkh8 Message-ID: Subject: Re: [PATCH 3/6] acpi,memory-hotplug : add physical memory hotplug code to acpi_memhotplug.c To: Yasuaki Ishimatsu Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, wency@cn.fujitsu.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 15 On Wed, Oct 3, 2012 at 6:09 AM, Yasuaki Ishimatsu wrote: > From: Yasuaki Ishimatsu > > For hot removing physical memory, the patch adds remove_memory() into > acpi_memory_remove_memory(). But we cannot support physical memory > hot remove. So remove_memory() do nothinig. I don't understand this explanation. Why do we need do nothing change? I guess you need to fold this patch into another meaningful fix. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/