Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983Ab2JETTv (ORCPT ); Fri, 5 Oct 2012 15:19:51 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:46619 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988Ab2JETTt (ORCPT ); Fri, 5 Oct 2012 15:19:49 -0400 Date: Fri, 5 Oct 2012 14:19:27 -0500 From: Kent Yoder To: "Eric W. Biederman" Cc: Ben Guthro , Linux Kernel Mailing List , Xiaoyan Zhang , Kent Yoder Subject: Re: Possible regression: BUG in fs/sysfs/group.c:65 Message-ID: <20121005191927.GA14645@ennui.austin.ibm.com> References: <87zk40ss2h.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zk40ss2h.fsf@xmission.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12100519-2398-0000-0000-00000BEAEE64 X-IBM-ISS-SpamDetectors: X-IBM-ISS-DetailInfo: BY=3.00000294; HX=3.00000196; KW=3.00000007; PH=3.00000001; SC=3.00000008; SDB=6.00179903; UDB=6.00040747; UTC=2012-10-05 19:19:46 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 13259 Lines: 230 On Fri, Oct 05, 2012 at 11:16:06AM -0700, Eric W. Biederman wrote: > Ben Guthro writes: > > > I am seeing a regression in today's (Oct 5) kernel - 2 WARNINGS, and a > > BUG below that seems to occur upon resuming from S3. > > > > I can start a bisection with 3.6 - but wanted to check to see if > > anyone else is also experiencing this failure... > > I took a quick look and this is a deterministic failure. The same > file is being added to sysfs twice. > > Since the routine causing this failure appears to be sys_add_ppi I > expect the commit that added this failure mode is the commit below. > > Xiaoyan Zhang, Kent Yoder can you guys look at this see why the tpm > code is adding itself multiple times into sysfs? It looks like the ppi sysfs teardown code is MIA. Xiaoyan, can you add it to tpm_ppi.c, with a caller in tpm_unregister_hardware? Kent > Thanks, > Eric > > commit f84fdff0fdcda7e509ce530e0ee612233a2104fb > Author: Xiaoyan Zhang > Date: Wed Aug 22 18:47:22 2012 +0800 > > driver: add PPI support in tpm driver > > The Physical Presence Interface enables the OS and the BIOS to cooperate and > provides a simple and straightforward platform user experience for > administering the TPM without sacrificing security. > > V2: separate the patch out in a separate source file, > add #ifdef CONFIG_ACPI so it compiles out on ppc, > use standard error instead of ACPI error as return code of show/store fns. > V3: move #ifdef CONFIG_ACPI from .c file to .h file. > V4: move tpm_ppi code from tpm module to tpm_bios module. > V5: modify sys_add_ppi() so that ppi_attr_grp doesn't need to be exported > > Signed-off-by: Xiaoyan Zhang > Signed-off-by: Kent Yoder > > > > I'm not sure that it matters in this case, but this is running as a > > Xen dom0 pvops kernel. > > > > Regards > > Ben Guthro > > > > > > [ 1554.684622] ------------[ cut here ]------------ > > [ 1554.684634] WARNING: at > > /data/home/bguthro/dev/unstable/linux/fs/sysfs/dir.c:536 > > sysfs_add_one+0xc0/0xf0() > > [ 1554.684636] Hardware name: 2765T6U > > [ 1554.684638] sysfs: cannot create duplicate filename '/devices/pnp0/00:0c/ppi' > > [ 1554.684640] Modules linked in: tpm_tis(+) tpm tpm_bios ehci_hcd > > ebtable_filter ebtables ip_tables x_tables zram(C) zsmalloc(C) bridge > > stp llc snd_hda_codec_conexant arc4 i915 snd_hda_intel iwldvm > > snd_hda_codec mac80211 pcmcia hid_generic drm_kms_helper yenta_socket > > snd_hwdep snd_pcm iwlwifi drm pcmcia_rsrc snd_timer pcmcia_core usbhid > > thinkpad_acpi coretemp snd_page_alloc cfg80211 psmouse hid > > i2c_algo_bit intel_agp serio_raw microcode intel_gtt snd soundcore > > video nvram ahci libahci e1000e [last unloaded: tpm_bios] > > [ 1554.684681] Pid: 3492, comm: modprobe Tainted: G C 3.6.0-orc #3 > > [ 1554.684683] Call Trace: > > [ 1554.684691] [] warn_slowpath_common+0x7f/0xc0 > > [ 1554.684695] [] warn_slowpath_fmt+0x46/0x50 > > [ 1554.684699] [] sysfs_add_one+0xc0/0xf0 > > [ 1554.684702] [] create_dir+0x7c/0xd0 > > [ 1554.684706] [] sysfs_create_dir+0x86/0xe0 > > [ 1554.684712] [] kobject_add_internal+0x9c/0x210 > > [ 1554.684716] [] kobject_add+0x67/0xc0 > > [ 1554.684720] [] kobject_create_and_add+0x3e/0x80 > > [ 1554.684725] [] sys_add_ppi+0x18/0x40 [tpm_bios] > > [ 1554.684731] [] tpm_register_hardware+0x22e/0x3c0 [tpm] > > [ 1554.684736] [] tpm_tis_init+0x44/0x601 [tpm_tis] > > [ 1554.684741] [] tpm_tis_pnp_init+0xee/0x10d [tpm_tis] > > [ 1554.684746] [] ? tpm_tis_init+0x601/0x601 [tpm_tis] > > [ 1554.684751] [] pnp_device_probe+0x70/0xf0 > > [ 1554.684757] [] ? driver_sysfs_add+0x7a/0xb0 > > [ 1554.684761] [] driver_probe_device+0x7b/0x240 > > [ 1554.684764] [] __driver_attach+0xab/0xb0 > > [ 1554.684768] [] ? driver_probe_device+0x240/0x240 > > [ 1554.684772] [] bus_for_each_dev+0x56/0x90 > > [ 1554.684776] [] driver_attach+0x1e/0x20 > > [ 1554.684779] [] bus_add_driver+0x190/0x290 > > [ 1554.684784] [] ? 0xffffffffa010cfff > > [ 1554.684787] [] driver_register+0x7a/0x160 > > [ 1554.684791] [] ? 0xffffffffa010cfff > > [ 1554.684795] [] pnp_register_driver+0x21/0x30 > > [ 1554.684800] [] init_tis+0x1d/0xc5 [tpm_tis] > > [ 1554.684805] [] ? __blocking_notifier_call_chain+0x63/0x80 > > [ 1554.684809] [] do_one_initcall+0x3f/0x170 > > [ 1554.684814] [] sys_init_module+0x8f/0x200 > > [ 1554.684819] [] system_call_fastpath+0x16/0x1b > > [ 1554.684822] ---[ end trace b394e16efa725e57 ]--- > > [ 1554.684825] ------------[ cut here ]------------ > > [ 1554.684829] WARNING: at > > /data/home/bguthro/dev/unstable/linux/lib/kobject.c:196 > > kobject_add_internal+0x1f4/0x210() > > [ 1554.684830] Hardware name: 2765T6U > > [ 1554.684832] kobject_add_internal failed for ppi with -EEXIST, don't > > try to register things with the same name in the same directory. > > [ 1554.684834] Modules linked in: tpm_tis(+) tpm tpm_bios ehci_hcd > > ebtable_filter ebtables ip_tables x_tables zram(C) zsmalloc(C) bridge > > stp llc snd_hda_codec_conexant arc4 i915 snd_hda_intel iwldvm > > snd_hda_codec mac80211 pcmcia hid_generic drm_kms_helper yenta_socket > > snd_hwdep snd_pcm iwlwifi drm pcmcia_rsrc snd_timer pcmcia_core usbhid > > thinkpad_acpi coretemp snd_page_alloc cfg80211 psmouse hid > > i2c_algo_bit intel_agp serio_raw microcode intel_gtt snd soundcore > > video nvram ahci libahci e1000e [last unloaded: tpm_bios] > > [ 1554.684870] Pid: 3492, comm: modprobe Tainted: G WC 3.6.0-orc #3 > > [ 1554.684872] Call Trace: > > [ 1554.684876] [] warn_slowpath_common+0x7f/0xc0 > > [ 1554.684880] [] warn_slowpath_fmt+0x46/0x50 > > [ 1554.684884] [] ? release_sysfs_dirent+0x61/0xe0 > > [ 1554.684888] [] kobject_add_internal+0x1f4/0x210 > > [ 1554.684892] [] kobject_add+0x67/0xc0 > > [ 1554.684897] [] kobject_create_and_add+0x3e/0x80 > > [ 1554.684901] [] sys_add_ppi+0x18/0x40 [tpm_bios] > > [ 1554.684906] [] tpm_register_hardware+0x22e/0x3c0 [tpm] > > [ 1554.684911] [] tpm_tis_init+0x44/0x601 [tpm_tis] > > [ 1554.684916] [] tpm_tis_pnp_init+0xee/0x10d [tpm_tis] > > [ 1554.684921] [] ? tpm_tis_init+0x601/0x601 [tpm_tis] > > [ 1554.684925] [] pnp_device_probe+0x70/0xf0 > > [ 1554.684929] [] ? driver_sysfs_add+0x7a/0xb0 > > [ 1554.684933] [] driver_probe_device+0x7b/0x240 > > [ 1554.684936] [] __driver_attach+0xab/0xb0 > > [ 1554.684940] [] ? driver_probe_device+0x240/0x240 > > [ 1554.684944] [] bus_for_each_dev+0x56/0x90 > > [ 1554.684947] [] driver_attach+0x1e/0x20 > > [ 1554.684951] [] bus_add_driver+0x190/0x290 > > [ 1554.684955] [] ? 0xffffffffa010cfff > > [ 1554.684958] [] driver_register+0x7a/0x160 > > [ 1554.684962] [] ? 0xffffffffa010cfff > > [ 1554.684966] [] pnp_register_driver+0x21/0x30 > > [ 1554.684970] [] init_tis+0x1d/0xc5 [tpm_tis] > > [ 1554.684974] [] ? __blocking_notifier_call_chain+0x63/0x80 > > [ 1554.684978] [] do_one_initcall+0x3f/0x170 > > [ 1554.684981] [] sys_init_module+0x8f/0x200 > > [ 1554.684985] [] system_call_fastpath+0x16/0x1b > > [ 1554.684987] ---[ end trace b394e16efa725e58 ]--- > > [ 1554.684990] kobject_create_and_add: kobject_add error: -17 > > [ 1554.685002] ------------[ cut here ]------------ > > [ 1554.685040] kernel BUG at > > /data/home/bguthro/dev/unstable/linux/fs/sysfs/group.c:65! > > [ 1554.685086] invalid opcode: 0000 [#1] SMP > > [ 1554.685118] Modules linked in: tpm_tis(+) tpm tpm_bios ehci_hcd > > ebtable_filter ebtables ip_tables x_tables zram(C) zsmalloc(C) bridge > > stp llc snd_hda_codec_conexant arc4 i915 snd_hda_intel iwldvm > > snd_hda_codec mac80211 pcmcia hid_generic drm_kms_helper yenta_socket > > snd_hwdep snd_pcm iwlwifi drm pcmcia_rsrc snd_timer pcmcia_core usbhid > > thinkpad_acpi coretemp snd_page_alloc cfg80211 psmouse hid > > i2c_algo_bit intel_agp serio_raw microcode intel_gtt snd soundcore > > video nvram ahci libahci e1000e [last unloaded: tpm_bios] > > [ 1554.685524] CPU 0 > > [ 1554.685540] Pid: 3492, comm: modprobe Tainted: G WC > > 3.6.0-orc #3 LENOVO 2765T6U/2765T6U > > [ 1554.685593] RIP: e030:[] [] > > internal_create_group+0x1e9/0x210 > > [ 1554.686670] RSP: e02b:ffff880002a4fbd8 EFLAGS: 00010246 > > [ 1554.686706] RAX: 0000000000000000 RBX: ffff880002ecc000 RCX: 000000000000a9c8 > > [ 1554.686747] RDX: ffffffffa00d8ec0 RSI: 0000000000000000 RDI: 0000000000000000 > > [ 1554.686788] RBP: ffff880002a4fc28 R08: 0000000000016640 R09: ffffea00009d7000 > > [ 1554.686829] R10: ffffffff812bfec9 R11: 6464615f646e615f R12: ffff88002871cc10 > > [ 1554.686870] R13: ffff880002ecc220 R14: ffffffffa00d8ec0 R15: 0000000000000000 > > [ 1554.686915] FS: 00007f33000ba700(0000) GS:ffff88002dc00000(0000) > > knlGS:0000000000000000 > > [ 1554.686963] CS: e033 DS: 0000 ES: 0000 CR0: 000000008005003b > > [ 1554.686996] CR2: 00007fac43cd0000 CR3: 000000000298a000 CR4: 0000000000002660 > > [ 1554.687038] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > [ 1554.687079] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 > > [ 1554.687121] Process modprobe (pid: 3492, threadinfo > > ffff880002a4e000, task ffff880025c52d20) > > [ 1554.687170] Stack: > > [ 1554.687184] ffffffffa00d8b38 0000000000000000 ffff880002a4fc08 > > ffffffff812bfd7c > > [ 1554.687238] 000000005b2d2d2d ffff880002ecc000 ffff88002871cc10 > > ffff880002ecc220 > > [ 1554.687292] ffff8800275c0e90 ffff880002ecc130 ffff880002a4fc38 > > ffffffff811d2a53 > > [ 1554.687345] Call Trace: > > [ 1554.687366] [] ? kobject_put+0x2c/0x60 > > [ 1554.687400] [] sysfs_create_group+0x13/0x20 > > [ 1554.687439] [] sys_add_ppi+0x27/0x40 [tpm_bios] > > [ 1554.687480] [] tpm_register_hardware+0x22e/0x3c0 [tpm] > > [ 1554.687523] [] tpm_tis_init+0x44/0x601 [tpm_tis] > > [ 1554.687562] [] tpm_tis_pnp_init+0xee/0x10d [tpm_tis] > > [ 1554.687604] [] ? tpm_tis_init+0x601/0x601 [tpm_tis] > > [ 1554.687645] [] pnp_device_probe+0x70/0xf0 > > [ 1554.687681] [] ? driver_sysfs_add+0x7a/0xb0 > > [ 1554.687718] [] driver_probe_device+0x7b/0x240 > > [ 1554.687756] [] __driver_attach+0xab/0xb0 > > [ 1554.687795] [] ? driver_probe_device+0x240/0x240 > > [ 1554.687832] [] bus_for_each_dev+0x56/0x90 > > [ 1554.687868] [] driver_attach+0x1e/0x20 > > [ 1554.687902] [] bus_add_driver+0x190/0x290 > > [ 1554.687939] [] ? 0xffffffffa010cfff > > [ 1554.687973] [] driver_register+0x7a/0x160 > > [ 1554.688009] [] ? 0xffffffffa010cfff > > [ 1554.688042] [] pnp_register_driver+0x21/0x30 > > [ 1554.688080] [] init_tis+0x1d/0xc5 [tpm_tis] > > [ 1554.688117] [] ? __blocking_notifier_call_chain+0x63/0x80 > > [ 1554.688161] [] do_one_initcall+0x3f/0x170 > > [ 1554.688197] [] sys_init_module+0x8f/0x200 > > [ 1554.688233] [] system_call_fastpath+0x16/0x1b > > [ 1554.688269] Code: 45 b0 0f 84 60 ff ff ff 48 8b 7d c8 89 45 b0 e8 > > 8e e7 ff ff 4c 8b 6d c8 8b 45 b0 e9 48 ff ff ff 48 83 7f 30 00 0f 85 > > 57 fe ff ff <0f> 0b be c3 00 00 00 48 c7 c7 f8 7e 7e 81 e8 04 10 e8 ff > > e9 80 > > [ 1554.688576] RIP [] internal_create_group+0x1e9/0x210 > > [ 1554.688621] RSP > > [ 1554.704039] ---[ end trace b394e16efa725e59 ]--- > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/