Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966Ab2JGQIA (ORCPT ); Sun, 7 Oct 2012 12:08:00 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:54111 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746Ab2JGQHv convert rfc822-to-8bit (ORCPT ); Sun, 7 Oct 2012 12:07:51 -0400 MIME-Version: 1.0 In-Reply-To: <914C6C58-5A3B-4F7D-94BE-EF6868ED5D9D@enac.fr> References: <1347630103-4105-1-git-send-email-benjamin.tissoires@gmail.com> <20121006220421.47f5fd56@endymion.delvare> <6F756B9E-DC87-4EF6-BB09-8A69A5F8C999@enac.fr> <20121006231111.6350c014@endymion.delvare> <914C6C58-5A3B-4F7D-94BE-EF6868ED5D9D@enac.fr> Date: Sun, 7 Oct 2012 18:07:50 +0200 Message-ID: Subject: Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation From: Benjamin Tissoires To: =?ISO-8859-1?Q?St=E9phane_Chatty?= Cc: Jiri Kosina , Jean Delvare , Dmitry Torokhov , =?ISO-8859-1?Q?Fabien_Andr=E9?= , =?Big5?B?vEK5xcJA?= , Ben Dooks , Wolfram Sang , linux-i2c@vger.kernel.org, USB list , linux-kernel@vger.kernel.org, Marcel Holtmann Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2060 Lines: 56 On Sat, Oct 6, 2012 at 11:39 PM, St?phane Chatty wrote: > > Le 6 oct. 2012 ? 23:28, Jiri Kosina a ?crit : > >> On Sat, 6 Oct 2012, Jiri Kosina wrote: >> >>>> My vote is a clear 3. It took me a few years to kick all users (as >>>> opposed to implementers) of i2c from drivers/i2c and finding them a >>>> proper home, I'm not going to accept new intruders. Grouping drivers >>>> according to what they implement makes it a lot easier to share code >>>> and ideas between related drivers. If you want to convince yourself, >>>> just imagine the mess it would be if all drivers for PCI devices lived >>>> under drivers/pci. >>> >>> This is more or less consistent with my original opinion when I was >>> refactoring the HID layer out of the individual drivers a few years ago. >>> >>> But Marcel objected that he wants to keep all the bluetooth-related >>> drivers under net/bluetooth, and I didn't really want to push hard against >>> this, because I don't have really super-strong personal preference either >>> way. >>> >>> But we definitely can use this oportunity to bring this up for discussion >>> again. >> >> Basically, to me this all boils down to the question -- what is more >> important: low-level transport being used, or the general function of the >> device? >> >> To me, it's the latter, and as such, everything would belong under >> drivers/hid. > > Then shouldn't is be drivers/input, rather? Ouch, it will introduce more and more complexity. It seems that hid transport layers should go in drivers/hid. However, I don't like mixing the transport layer and the final drivers. Maybe this is the time to rework a little bit the tree. To minimize the moves, we could introduce: drivers/hid/busses/usb drivers/hid/busses/i2c drivers/hid/busses/bluetooth Cheers, Benjamin > > St. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/