Message-ID: <1349626414.15802.2.camel@joe-AO722>
Subject: Re: [PATCH 2/5] mfd: tps65090: add error prints when mem alloc
 failed
From: Joe Perches <joe@perches.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org,
        vbyravarasu@nvidia.com
Date: Sun, 07 Oct 2012 09:13:34 -0700
In-Reply-To: <1349623340-21807-3-git-send-email-ldewangan@nvidia.com>
References: <1349623340-21807-1-git-send-email-ldewangan@nvidia.com>
	 <1349623340-21807-3-git-send-email-ldewangan@nvidia.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 999
Lines: 31

On Sun, 2012-10-07 at 20:52 +0530, Laxman Dewangan wrote:
> Add error prints when memory allocation failed for
> tps65090 data. Also cleanups the melloc arguments.

The new dev_err is unnecessary.
A dump_stack is already done on alloc failures.
The sizeof(* is ok.


> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
[]
> @@ -263,10 +263,11 @@ static int __devinit tps65090_i2c_probe(struct i2c_client *client,
>  		return -EINVAL;
>  	}
>  
> -	tps65090 = devm_kzalloc(&client->dev, sizeof(struct tps65090),
> -		GFP_KERNEL);
> -	if (tps65090 == NULL)
> +	tps65090 = devm_kzalloc(&client->dev, sizeof(*tps65090), GFP_KERNEL);
> +	if (!tps65090) {
> +		dev_err(&client->dev, "mem alloc for tps65090 failed\n");
>  		return -ENOMEM;
> +	}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/