Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962Ab2JGWeF (ORCPT ); Sun, 7 Oct 2012 18:34:05 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:53478 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989Ab2JGWeD (ORCPT ); Sun, 7 Oct 2012 18:34:03 -0400 MIME-Version: 1.0 In-Reply-To: References: <1349637532-27466-1-git-send-email-elezegarcia@gmail.com> Date: Sun, 7 Oct 2012 19:34:02 -0300 Message-ID: Subject: Re: [PATCH v2] Makefile: Add option to disable gcc automatic inlining From: Ezequiel Garcia To: Andi Kleen Cc: linux-kernel@vger.kernel.org, Tim Bird , mmarek@suse.cz, sam@ravnborg.org, rientjes@google.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 29 On Sun, Oct 7, 2012 at 7:21 PM, Andi Kleen wrote: > Ezequiel Garcia writes: > >> The new option is CONFIG_CC_DISABLE_AUTO_INLINE and it's >> located at: >> * Kernel hacking >> * Disable gcc automatic inlining > > You don't state anywhere why you want that? > This is important -if not necessary- to trace memory allocations with ftrace kmem events. Allocations are traced through _RET_IP_ macro, which in turn only works accurately if gcc don't inline. Without this patch you will trace callsites like kstrdup, instead of the real caller. Perhaps I should explain this better in the commit message? Thanks for reviewing, Ezequiel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/