Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064Ab2JHIbh (ORCPT ); Mon, 8 Oct 2012 04:31:37 -0400 Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:6014 "EHLO mail4-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752712Ab2JHIbg (ORCPT ); Mon, 8 Oct 2012 04:31:36 -0400 X-IronPort-AV: E=Sophos;i="4.80,551,1344204000"; d="scan'208";a="158222143" Date: Mon, 8 Oct 2012 10:31:33 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Ryan Mallon cc: Mauro Carvalho Chehab , Joe Perches , Julia Lawall , walter harms , Antti Palosaari , kernel-janitors@vger.kernel.org, shubhrajyoti@ti.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization In-Reply-To: <50723661.6040107@gmail.com> Message-ID: References: <1349624323-15584-1-git-send-email-Julia.Lawall@lip6.fr> <1349624323-15584-3-git-send-email-Julia.Lawall@lip6.fr> <5071AEF3.6080108@bfs.de> <5071B834.1010200@bfs.de> <1349633780.15802.8.camel@joe-AO722> <1349645970.15802.12.camel@joe-AO722> <1349646718.15802.16.camel@joe-AO722> <20121007225639.364a41b4@infradead.org> <50723661.6040107@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 18 I found only 15 uses of I2C_MSG_OP, out of 653 uses of one of the three macros. Since I2C_MSG_OP has the complete set of flags, I think it should be OK? One of the uses, in drivers/media/i2c/adv7604.c, is as follows: struct i2c_msg msg[2] = { { client->addr, 0, 1, msgbuf0 }, { client->addr, 0 | I2C_M_RD, len, msgbuf1 } I'm not sure what was intended, but I guess the second structure is supposed to only do a read? julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/