Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901Ab2JHLPU (ORCPT ); Mon, 8 Oct 2012 07:15:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:47826 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941Ab2JHLPQ (ORCPT ); Mon, 8 Oct 2012 07:15:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,553,1344236400"; d="scan'208";a="231206995" Message-ID: <5072B5C0.4010309@linux.intel.com> Date: Mon, 08 Oct 2012 19:15:12 +0800 From: Haicheng Li User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120306 Thunderbird/3.1.20 MIME-Version: 1.0 To: Haicheng Li CC: davem@davemloft.net, haicheng.li@linux.jf.intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, fengguang.wu@intel.com Subject: Re: [PATCH] pch_pge: Fix build error by selecting all the possible dependencies. References: <20121006075954.GA29618@localhost> <1349670580-11158-1-git-send-email-haicheng.lee@gmail.com> In-Reply-To: <1349670580-11158-1-git-send-email-haicheng.lee@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1927 Lines: 46 Just realized a typo in the subject, pls. ignore this. will send a new soon. sorry. On 10/08/2012 12:29 PM, Haicheng Li wrote: > Fengguang reported a kernel build failure as folowing: > drivers/built-in.o: In function `pch_gbe_ioctl': > pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write' > pch_gbe_main.c:(.text+0x510393): undefined reference to `pch_ch_control_write' > pch_gbe_main.c:(.text+0x5103b3): undefined reference to `pch_ch_control_write' > .. > > It's a regression by commit da1586461. The root cause is that > the CONFIG_PPS is not set there, consequently CONFIG_PTP_1588_CLOCK > can not be set anyway, which finally causes ptp_pch and pch_gbe_main > build failures. > > As David prefers to use *select* to fix such module co-dependency issues, > this patch explicitly selects all the possible dependencies of PCH_PTP. > > Reported-by: Fengguang Wu > Reviewed-by: David S. Miller > Signed-off-by: Haicheng Li > --- > drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig > index 9730241..5296cc8 100644 > --- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig > +++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig > @@ -26,6 +26,9 @@ if PCH_GBE > config PCH_PTP > bool "PCH PTP clock support" > default n > + depends on EXPERIMENTAL > + select PPS > + select PTP_1588_CLOCK > select PTP_1588_CLOCK_PCH > ---help--- > Say Y here if you want to use Precision Time Protocol (PTP) in the -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/