Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953Ab2JHOSg (ORCPT ); Mon, 8 Oct 2012 10:18:36 -0400 Received: from ud10.udmedia.de ([194.117.254.50]:37699 "EHLO mail.ud10.udmedia.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799Ab2JHOSc (ORCPT ); Mon, 8 Oct 2012 10:18:32 -0400 Date: Mon, 8 Oct 2012 16:18:29 +0200 From: Markus Trippelsdorf To: "Wouter M. Koolen" Cc: lkml , jim.cromie@gmail.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, jbaron@redhat.com, Greg KH Subject: Re: [bisected] stray angle bracket in dmesg Message-ID: <20121008141829.GA244@x4> References: <5072DD92.2000305@cwi.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5072DD92.2000305@cwi.nl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 39 On 2012.10.08 at 15:05 +0100, Wouter M. Koolen wrote: > Hi guys, > > After upgrading from 3.5.4 to 3.5.5 I started noticing log lines of the > form (just a random sample) > > pci_bus 0000:00: >resource 4 [io 0x0000-0x0cf7] > pnp 00:07: >Plug and Play ACPI device, IDs PNP0303 (active) > system 00:04: >[io 0x0680-0x069f] has been reserved > pci_root PNP0A08:00: >host bridge window [io 0x0000-0x0cf7] > > Note the right angle bracket between the device name and the message > string. These angle brackets were not there up till 3.5.4. > > This does not happen in all dmesg lines. Only the ones that start with a > device identifier. > > I assume this angle bracket was not intentional. Otherwise please excuse > the noise. > > I noticed this because all of these lines now suddenly slip through my > logcheck ignore rules. > > Bisection points to this commit: > > commit 3d822616ca81881d8c19d0b473e79ba241c700de > Author: Markus Trippelsdorf > Date: Sat Aug 18 18:35:51 2012 -0600 This patch should be reverted for stable, since the move to ASCII SOH ( commit 04d2c8c83d0) wasn't backported. So the fix just isn't necessary. -- Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/