Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956Ab2JHTW2 (ORCPT ); Mon, 8 Oct 2012 15:22:28 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:57155 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845Ab2JHTWY (ORCPT ); Mon, 8 Oct 2012 15:22:24 -0400 Date: Mon, 08 Oct 2012 15:22:21 -0400 (EDT) Message-Id: <20121008.152221.1598558544115876006.davem@davemloft.net> To: florz@florz.de Cc: kaber@trash.net, eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jpirko@redhat.com Subject: Re: [PATCH v2] vlan: don't deliver frames for unknown vlans to protocols From: David Miller In-Reply-To: <20121008191944.GD25288@florz.florz.dyndns.org> References: <20121008015158.GE25895@florz.florz.dyndns.org> <20121008.144230.1404596032615788891.davem@davemloft.net> <20121008191944.GD25288@florz.florz.dyndns.org> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 18 From: Florian Zumbiehl Date: Mon, 8 Oct 2012 21:19:44 +0200 > The only way to reach the new check without another_round and with a > non-zero tag is the first return false, which happens if there is no device > for the tag, in which case setting PACKET_OTHERHOST should be the right > thing to do (in particular, a non-existent vlan device won't have the > frame's MAC address). I am assuming that rx_handlers don't modify the > frame unless they return RX_HANDLER_ANOTHER. Indeed, you're right. Patch applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/