Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030Ab2JIGT7 (ORCPT ); Tue, 9 Oct 2012 02:19:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42003 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615Ab2JIGT6 (ORCPT ); Tue, 9 Oct 2012 02:19:58 -0400 Date: Tue, 9 Oct 2012 08:19:42 +0200 (CEST) From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= X-X-Sender: lukas@dhcp-1-104.brq.redhat.com To: Zhao Hongjiang cc: jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" , serge.hallyn@canonical.com, containers@lists.linux-foundation.org Subject: Re: [PATCH] ext3: fix return values on parse_options() failure In-Reply-To: <5073BABF.8090206@gmail.com> Message-ID: References: <5073BABF.8090206@gmail.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2128 Lines: 61 On Tue, 9 Oct 2012, Zhao Hongjiang wrote: > Date: Tue, 09 Oct 2012 13:48:47 +0800 > From: Zhao Hongjiang > To: jack@suse.cz > Cc: akpm@linux-foundation.org, adilger.kernel@dilger.ca, > linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, > Eric W. Biederman , serge.hallyn@canonical.com, > containers@lists.linux-foundation.org > Subject: [PATCH] ext3: fix return values on parse_options() failure > > From: Zhao Hongjiang > > parse_options() in ext3 should return 0 when parse the mount options fails. > Ah, it really is a joy to read the parse_options() :). But this fix makes sense, thanks for catching it. Reviewed-by: Lukas Czerner -Lukas > Signed-off-by: Zhao Hongjiang > --- > fs/ext3/super.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext3/super.c b/fs/ext3/super.c > index 17ae5c8..ebf8312 100644 > --- a/fs/ext3/super.c > +++ b/fs/ext3/super.c > @@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb, > uid = make_kuid(current_user_ns(), option); > if (!uid_valid(uid)) { > ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option); > - return -1; > + return 0; > > } > sbi->s_resuid = uid; > @@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb, > gid = make_kgid(current_user_ns(), option); > if (!gid_valid(gid)) { > ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option); > - return -1; > + return 0; > } > sbi->s_resgid = gid; > break; > -- 1.7.1 > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/