Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275Ab2JIG7P (ORCPT ); Tue, 9 Oct 2012 02:59:15 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:55226 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811Ab2JIG7M (ORCPT ); Tue, 9 Oct 2012 02:59:12 -0400 Date: Mon, 8 Oct 2012 23:59:07 -0700 From: Jonathan Nieder To: Feng Tang Cc: Len Brown , "linux-acpi@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Brown, Len" , "stable@vger.kernel.org" Subject: Re: [PATCH 27/30] ACPI: EC: Add a quirk for CLEVO M720T/M730T laptop Message-ID: <20121009065907.GB3648@elie.Belkin> References: <67bfa9b60bd689601554526d144b21d529f78a09.1349761836.git.len.brown@intel.com> <20121009061633.GA3648@elie.Belkin> <20121009142206.63dd9981@feng-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121009142206.63dd9981@feng-i7> User-Agent: Mutt/1.5.21+51 (9e756d1adb76) (2011-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 32 Feng Tang wrote: > Jonathan Nieder wrote: >> What would go wrong if the threshold were just increased to 20 on all >> models? > > Then some other platform will stop to work. > https://bugzilla.kernel.org/show_bug.cgi?id=11892 > > The 26/30 and 27/30 patches are bound together to fix one bug. Some > quote from description from the 26th patch: > > ACPI_EC_STORM_THRESHOLD was initially 20 when it's created, and > was changed to 8 in 2.6.28 commit 06cf7d3c7 "ACPI: EC: lower interrupt storm > threshold" to fix kernel bug 11892 by forcing the laptop in that bug to > work in polling mode. > > Hope this answers your question. Thanks much. Yes, that clarifies. The magic numbers are not too thrilling. If the polling mode just doesn't work on the Clevo M720, why isn't the appropriate storm threshold 999999 or infinity rather than 20? Do we know why the polling mode doesn't work? Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/