Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754145Ab2JIIlc (ORCPT ); Tue, 9 Oct 2012 04:41:32 -0400 Received: from twin.jikos.cz ([89.185.236.188]:45019 "EHLO twin.jikos.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725Ab2JIIl2 (ORCPT ); Tue, 9 Oct 2012 04:41:28 -0400 Date: Tue, 9 Oct 2012 10:39:10 +0200 From: David Sterba To: Andi Kleen Cc: "Markus F.X.J. Oberhumer" , linux-kernel@vger.kernel.org, chris.mason@fusionio.com, linux-btrfs@vger.kernel.org, Nitin Gupta , Richard Purdie , David Sterba Subject: Re: ANN: linux-kernel-lzo-2.06.20120123 - update LZO to v2.06 Message-ID: <20121009083910.GI4405@twin.jikos.cz> Reply-To: dave@jikos.cz Mail-Followup-To: Andi Kleen , "Markus F.X.J. Oberhumer" , linux-kernel@vger.kernel.org, chris.mason@fusionio.com, linux-btrfs@vger.kernel.org, Nitin Gupta , Richard Purdie , David Sterba References: <1326414530-10789-1-git-send-email-andi@firstfloor.org> <4F16DFB0.2060404@oberhumer.com> <4F1D889C.2050706@oberhumer.com> <20120125013618.GA11715@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120125013618.GA11715@one.firstfloor.org> User-Agent: Mutt/1.5.21 (2011-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 34 On Wed, Jan 25, 2012 at 02:36:18AM +0100, Andi Kleen wrote: > I ran benchmarks on the new miniLZO and LZ4 on 64bit. LZ4 is generally slower > than snappy/lzo in the micro benchmarks. And the reason why you measured worse speed for LZ4 although (AFAICT) everybody else's measurements claim the opposite is quite simple: likely due to a copy&paste error you did not benchmark LZ4 at all: https://github.com/andikleen/snappy-c/blob/master/glue.c#L282 274 void test_lz4(char *map, size_t size, char *fn) 275 { 276 int i; 277 int err; 278 size_t outlen = size * 2; 279 char *out = xmalloc(outlen); 280 char *buf2 = xmalloc(size); 281 282 BENCH(fastlz, "lz4", fn, NULL); ^^^^^^ 283 284 free(out); 285 free(buf2); 286 } (LZ4 is on it's track towards kernel) david -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/