Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755430Ab2JIKaU (ORCPT ); Tue, 9 Oct 2012 06:30:20 -0400 Received: from eu1sys200aog116.obsmtp.com ([207.126.144.141]:57126 "EHLO eu1sys200aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755368Ab2JIKaP convert rfc822-to-8bit (ORCPT ); Tue, 9 Oct 2012 06:30:15 -0400 From: Sjur BRENDELAND To: Ohad Ben-Cohen , Fengguang Wu , "Linus Walleij (linus.walleij@linaro.org)" Cc: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 9 Oct 2012 12:30:01 +0200 Subject: RE: [remoteproc:for-next 6/9] remoteproc_virtio.c:(.text+0x238e7e): undefined reference to `vring_transport_features' Thread-Topic: [remoteproc:for-next 6/9] remoteproc_virtio.c:(.text+0x238e7e): undefined reference to `vring_transport_features' Thread-Index: Ac2mBHCSXgvWeecIQNKGyVzzwytoggAAAUUg Message-ID: <81C3A93C17462B4BBD7E272753C1057923BD9B59E3@EXDCVYMBSTM005.EQ1STM.local> References: <20121001024544.GA12711@localhost> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 46 Hi Ohad, > On Tue, Oct 2, 2012 at 10:24 AM, Ohad Ben-Cohen > wrote: > > On Mon, Oct 1, 2012 at 4:45 AM, Fengguang Wu > wrote: > >> Hi Ohad, > >> > >> FYI, kernel build failed on > >> > >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git > for-next > >> head: bec109a430e8c67bae1743f7e71898283234a77f > >> commit: ec4d02d9180f407c41f8310a13b34e473c671fbb [6/9] remoteproc: > Add STE modem driver > >> config: i386-randconfig-b102 (attached as .config) > >> > >> It should be an old bug. The commit happen to be the one to trigger > >> the errors because it selects CONFIG_EMOTEPROC. > > > > Thanks Fengguang. > > > > This should be fixed by a patch I pushed today to remoteproc's for-next > branch. > > > > Though I wonder, Sjur, do we want to limit the architectures/platforms > > where the STE modem driver can be selected on ? Is it ARM only perhaps ? > > Can you please address the above question ? Sorry for not responding sooner, but I thought this issue was solved with your patch "remoteproc: fix (again) the virtio-related build breakage" (https://lkml.org/lkml/2012/10/6/85). I'm not sure I understand why you would want to add a dependency to ARM. But if you're uncomfortable by having STE_MODEM_RPROC directly selectable, perhaps we could let it be selected by arch specific Kconfig files, e.g. mach-ux500? Regards, Sjur -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/