Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294Ab2JILLs (ORCPT ); Tue, 9 Oct 2012 07:11:48 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:4787 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218Ab2JILLq (ORCPT ); Tue, 9 Oct 2012 07:11:46 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Tue, 09 Oct 2012 04:09:30 -0700 Message-ID: <5074065B.3040103@nvidia.com> Date: Tue, 9 Oct 2012 16:41:23 +0530 From: Venu Byravarasu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Laxman Dewangan CC: "broonie@opensource.wolfsonmicro.com" , "lrg@ti.com" , "sameo@linux.intel.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 4/4] regulator: tps65090: add external control support for DCDC References: <1349776142-6409-1-git-send-email-ldewangan@nvidia.com> <1349776142-6409-5-git-send-email-ldewangan@nvidia.com> <5073F63B.9020606@nvidia.com> In-Reply-To: <5073F63B.9020606@nvidia.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 19 On Tuesday 09 October 2012 03:32 PM, Laxman Dewangan wrote: > On Tuesday 09 October 2012 04:03 PM, Venu Byravarasu wrote: >>> +static struct regulator_ops tps65090_ext_control_ops = { >>> +}; >> What is the purpose of adding empty structure? >> > We will not able to register regulator if there is no ops. > In regulator register: > if (regulator_desc->name == NULL || regulator_desc->ops == NULL) > return ERR_PTR(-EINVAL); > If tps65090_ops would be left as is, without renaming it, hope this empty structure can be removed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/