Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755949Ab2JINvB (ORCPT ); Tue, 9 Oct 2012 09:51:01 -0400 Received: from g6t0186.atlanta.hp.com ([15.193.32.63]:27714 "EHLO g6t0186.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755783Ab2JINu6 (ORCPT ); Tue, 9 Oct 2012 09:50:58 -0400 Message-ID: <1349790229.23493.2.camel@misato.fc.hp.com> Subject: Re: [PATCH v2] ACPI: Add ACPI CPU hot-remove support From: Toshi Kani To: lenb@kernel.org Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, isimatu.yasuaki@jp.fujitsu.com, prarit@redhat.com, imammedo@redhat.com, vijaymohan.pandarathil@hp.com Date: Tue, 09 Oct 2012 07:43:49 -0600 In-Reply-To: <1345841699-20067-1-git-send-email-toshi.kani@hp.com> References: <1345841699-20067-1-git-send-email-toshi.kani@hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2920 Lines: 86 Hi Len, Can you please review this patch? Please let me know if there is anything I need to do for 3.7. Thanks, -Toshi On Fri, 2012-08-24 at 14:54 -0600, Toshi Kani wrote: > Added CPU hot-remove support through an ACPI eject notification. > It calls acpi_bus_hot_remove_device(), which shares the same code > path with the sysfs eject operation. acpi_os_hotplug_execute() > serializes hot-remove operations between ACPI hot-remove and sysfs > eject requests. > > v2: > - Rebased to 3.6-rc3. > > Signed-off-by: Toshi Kani > Reviewed-by: Yasuaki Ishimatsu > Tested-by: IgorMammedov > Tested-by: Vijay Mohan Pandarathil > Tested-by: Prarit Bhargava > --- > drivers/acpi/processor_driver.c | 27 +++++++++++++++++---------- > 1 files changed, 17 insertions(+), 10 deletions(-) > > diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c > index bfc31cb..d12e9c3 100644 > --- a/drivers/acpi/processor_driver.c > +++ b/drivers/acpi/processor_driver.c > @@ -694,8 +694,8 @@ int acpi_processor_device_add(acpi_handle handle, struct acpi_device **device) > static void acpi_processor_hotplug_notify(acpi_handle handle, > u32 event, void *data) > { > - struct acpi_processor *pr; > struct acpi_device *device = NULL; > + struct acpi_eject_event *ej_event = NULL; > u32 ost_code = ACPI_OST_SC_NON_SPECIFIC_FAILURE; /* default */ > int result; > > @@ -727,20 +727,27 @@ static void acpi_processor_hotplug_notify(acpi_handle handle, > "received ACPI_NOTIFY_EJECT_REQUEST\n")); > > if (acpi_bus_get_device(handle, &device)) { > - printk(KERN_ERR PREFIX > - "Device don't exist, dropping EJECT\n"); > + pr_err(PREFIX "Device don't exist, dropping EJECT\n"); > break; > } > - pr = acpi_driver_data(device); > - if (!pr) { > - printk(KERN_ERR PREFIX > - "Driver data is NULL, dropping EJECT\n"); > + if (!acpi_driver_data(device)) { > + pr_err(PREFIX "Driver data is NULL, dropping EJECT\n"); > break; > } > > - /* REVISIT: update when eject is supported */ > - ost_code = ACPI_OST_SC_EJECT_NOT_SUPPORTED; > - break; > + ej_event = kmalloc(sizeof(*ej_event), GFP_KERNEL); > + if (!ej_event) { > + pr_err(PREFIX "No memory, dropping EJECT\n"); > + break; > + } > + > + ej_event->handle = handle; > + ej_event->event = ACPI_NOTIFY_EJECT_REQUEST; > + acpi_os_hotplug_execute(acpi_bus_hot_remove_device, > + (void *)ej_event); > + > + /* eject is performed asynchronously */ > + return; > > default: > ACPI_DEBUG_PRINT((ACPI_DB_INFO, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/