Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754413Ab2JIQID (ORCPT ); Tue, 9 Oct 2012 12:08:03 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:49168 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328Ab2JIQIA (ORCPT ); Tue, 9 Oct 2012 12:08:00 -0400 Date: Tue, 9 Oct 2012 17:06:47 +0100 From: Russell King - ARM Linux To: Jonathan Austin Cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Stephen Boyd , Will Deacon Subject: Re: [PATCH 4/9] ARM: export default read_current_timer Message-ID: <20121009160647.GG4625@n2100.arm.linux.org.uk> References: <1349796183-30648-1-git-send-email-arnd@arndb.de> <1349796183-30648-5-git-send-email-arnd@arndb.de> <50744586.6010806@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50744586.6010806@arm.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 28 On Tue, Oct 09, 2012 at 04:40:54PM +0100, Jonathan Austin wrote: > Hi Arnd, > > On 09/10/12 16:22, Arnd Bergmann wrote: > > diff --git a/arch/arm/lib/delay.c b/arch/arm/lib/delay.c > > index 9d0a300..0dc5385 100644 > > --- a/arch/arm/lib/delay.c > > +++ b/arch/arm/lib/delay.c > > @@ -45,6 +45,7 @@ int read_current_timer(unsigned long *timer_val) > > *timer_val = delay_timer->read_current_timer(); > > return 0; > > } > > +EXPORT_SYMBOL_GPL(read_current_timer); > > > Perhaps this fits better in armksyms.c? That way it lives with > arm_delay_ops and friends. It's always much better to put things next to where they're defined rather than spreading them around. armksyms.c is a reminant of the 1.x days of doing things... but still remains to allow what are mostly assembly symbols to be exported. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/