Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753975Ab2JITr7 (ORCPT ); Tue, 9 Oct 2012 15:47:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54849 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810Ab2JITr4 (ORCPT ); Tue, 9 Oct 2012 15:47:56 -0400 Date: Tue, 9 Oct 2012 12:47:55 -0700 From: Andrew Morton To: Greg KH Cc: KY Srinivasan , "olaf@aepfle.de" , "linux-kernel@vger.kernel.org" , "andi@firstfloor.org" , "apw@canonical.com" , "devel@linuxdriverproject.org" Subject: Re: [PATCH 1/2] mm: Export vm_committed_as Message-Id: <20121009124755.ce1087b4.akpm@linux-foundation.org> In-Reply-To: <20121008133539.GA15490@kroah.com> References: <1349654347-18337-1-git-send-email-kys@microsoft.com> <1349654386-18378-1-git-send-email-kys@microsoft.com> <20121008004358.GA12342@kroah.com> <426367E2313C2449837CD2DE46E7EAF930A1FB31@SN2PRD0310MB382.namprd03.prod.outlook.com> <20121008133539.GA15490@kroah.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1797 Lines: 41 On Mon, 8 Oct 2012 06:35:39 -0700 Greg KH wrote: > On Mon, Oct 08, 2012 at 03:35:50AM +0000, KY Srinivasan wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > Sent: Sunday, October 07, 2012 8:44 PM > > > To: KY Srinivasan > > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > > > apw@canonical.com; akpm@linux-foundation.org; andi@firstfloor.org > > > Subject: Re: [PATCH 1/2] mm: Export vm_committed_as > > > > > > On Sun, Oct 07, 2012 at 04:59:45PM -0700, K. Y. Srinivasan wrote: > > > > The policy engine on the host expects the guest to report the > > > > committed_as. Since this variable is not exported, > > > > export this symbol. > > > > > > Why are these symbols not needed by either Xen or KVM or vmware, which > > > I think all support the same thing, right? > > > > The basic balloon driver does not need this symbol since the basic balloon driver > > is not automatically driven by the host. On the Windows host we have a policy engine that > > drives the balloon driver based on both guest level memory pressure that the guest > > reports as well as other system level metrics the host maintains. We need this symbol to > > drive the policy engine on the host. > > Ok, but you're going to have to get the -mm developers to agree that > this is ok before I can accept it. Well I guess it won't kill us. I do wonder what relevance vm_committed_as has to processes which are running within a memcg container? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/