Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757108Ab2JIVzX (ORCPT ); Tue, 9 Oct 2012 17:55:23 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:47471 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757088Ab2JIVzR (ORCPT ); Tue, 9 Oct 2012 17:55:17 -0400 MIME-Version: 1.0 In-Reply-To: <1348179300-11653-1-git-send-email-keescook@chromium.org> References: <1348179300-11653-1-git-send-email-keescook@chromium.org> From: Michael Kerrisk Date: Tue, 9 Oct 2012 23:54:55 +0200 X-Google-Sender-Auth: v9pjsnUnnrd_-5wP6jfQQ8pmrFk Message-ID: Subject: Re: [PATCH 1/4] module: add syscall to load module from fd To: Kees Cook Cc: linux-kernel@vger.kernel.org, Andrew Morton , Rusty Russell , Mimi Zohar , Serge Hallyn , Arnd Bergmann , James Morris , Al Viro , Eric Paris , Jiri Kosina , linux-security-module@vger.kernel.org, "H. Peter Anvin" , Michael Kerrisk Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 25 Kees, > +SYSCALL_DEFINE2(finit_module, int, fd, const char __user *, uargs) Given the repeated experience of the last few years--new system calls that are in essence revisions of older system calls with a 'flags' argument bolted on to allow more flexible behavior (e.g., accept4(), dup3(), utimensat(), epoll_create1(), pipe2(), inotify_init(1), and so on.)--maybe it is worth considering adding a 'flags' bit mask argument[1] to the finti_module() system call now, to allow for possible future extensions to the behavior of the interface. What do you think? Thanks, Michael [1] Yes, I know that init_module() doesn't have a flags argument, but that interface was added when we'd seen fewer of the kinds of cases listed above. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/