Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757346Ab2JJBkH (ORCPT ); Tue, 9 Oct 2012 21:40:07 -0400 Received: from mga02.intel.com ([134.134.136.20]:35554 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755238Ab2JJBkD convert rfc822-to-8bit (ORCPT ); Tue, 9 Oct 2012 21:40:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,562,1344236400"; d="scan'208";a="203682142" From: "Zheng, Lv" To: Konrad Rzeszutek Wilk CC: "Brown, Len" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jason Wessel , "Tang, Feng" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "x86@kernel.org" , "platform-driver-x86@vger.kernel.org" Subject: RE: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2. Thread-Topic: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2. Thread-Index: AQHNpccPIkmRrmh9DEqFt+BQNxKiaJewrgcAgAEWBLA= Date: Wed, 10 Oct 2012 01:40:00 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88B9C9E2@SHSMSX101.ccr.corp.intel.com> References: <6a6a79654294bf4a3a9df1cf81880a44aeea4b44.1349749925.git.lv.zheng@intel.com> <20121009170220.GE25276@phenom.dumpdata.com> In-Reply-To: <20121009170220.GE25276@phenom.dumpdata.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 458 Lines: 13 > > +int __init acpi_early_console_keep(struct acpi_debug_port *info) > > Why not make it 'bool' like the other (acpi_early_console_enabled)? NAK. "keep" is "int" in "setup_early_printk". Best regards/Lv Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/