Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353Ab2JJE6U (ORCPT ); Wed, 10 Oct 2012 00:58:20 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:5746 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599Ab2JJE6Q (ORCPT ); Wed, 10 Oct 2012 00:58:16 -0400 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Tue, 09 Oct 2012 21:55:58 -0700 Message-ID: <50750051.10701@nvidia.com> Date: Wed, 10 Oct 2012 10:27:53 +0530 From: Venu Byravarasu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Kevin Hilman CC: "rtc-linux@googlegroups.com" , Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" Subject: Re: [PATCH] rtc: kconfig: fix RTC_INTF defaults connected to RTC_CLASS References: <1349827784-8646-1-git-send-email-khilman@deeprootsystems.com> In-Reply-To: <1349827784-8646-1-git-send-email-khilman@deeprootsystems.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1319 Lines: 32 On Wednesday 10 October 2012 05:39 AM, Kevin Hilman wrote: > From: Kevin Hilman > > commit 6b8029fab64164b5895d58d23229b75c82e3a6fc (rtc: kconfig: remove > unnecessary dependencies) removed various 'depends on RTC_CLASS' > dependencies but also removed a few 'default RTC_CLASS' statements, > which actually changed default behavior. > > This resulted in the various RTC interfaces (sysfs, proc, dev) all > being disabled by default, even when RTC_CLASS is enabled: > > # CONFIG_RTC_INTF_SYSFS is not set > # CONFIG_RTC_INTF_PROC is not set > # CONFIG_RTC_INTF_DEV is not set > > which is different from previous behavior (all of these where enabled.) > > To fix, add back the 'default RTC_CLASS' statments to each of the > RTC_INTF_* options. Thanks for fixing this. > config RTC_INTF_DEV > boolean "/dev/rtcN (character devices)" > + default RTC_CLASS > help > Say yes here if you want to use your RTCs using the /dev > interfaces, which "udev" sets up as /dev/rtc0 through Acked-by: Venu Byravarasu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/