From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
To: "'Stefan Hajnoczi'" <stefanha@gmail.com>
Cc: linux-kernel@vger.kernel.org
References: <000901cda2f0$7d773eb0$7865bc10$%kim@samsung.com>
 <20121007064222.GA436@stefanha-thinkpad>
In-reply-to: <20121007064222.GA436@stefanha-thinkpad>
Subject: RE: [PATCH 02/16] f2fs: add on-disk layout
Date: Wed, 10 Oct 2012 14:52:56 +0900
Message-id: <009901cda6ab$7f00a6e0$7d01f4a0$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=Windows-1252
Content-transfer-encoding: 7bit
Thread-index: Ac2kVu309gb6EOauTJmta56HKJQ1+wCUXHvQ
Content-language: ko
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1630
Lines: 54

[snip]

> > +/*
> > + * For superblock
> > + */
> > +struct f2fs_super_block {
> > +	__le32 magic;		/* Magic Number */
> > +	__le16 major_ver;	/* Major Version */
> > +	__le16 minor_ver;	/* Minor Version */
> > +	__le32 log_sectorsize;	/* log2 (Sector size in bytes) */
> > +	__le32 log_sectors_per_block;	/* log2 (Number of sectors per block */
> > +	__le32 log_blocksize;	/* log2 (Block size in bytes) */
> 
> Why store log_blocksize on disk when it can be calculated from
> log_sectorsize and log_sectors_per_block?  It may be handy to keep this
> in the in-memory superblock but keeping it on-disk means you need a
> consistency check and error code path when loading the superblock.
> 

Yes, I added this for sanity check of superblock.

> > +struct f2fs_inode {
> > +	__le16 i_mode;			/* File mode */
> > +	__le16 i_reserved;		/* Reserved */
> > +	__le32 i_uid;			/* User ID */
> > +	__le32 i_gid;			/* Group ID */
> > +	__le32 i_links;			/* Links count */
> > +	__le64 i_size;			/* File size in bytes */
> > +	__le64 i_blocks;		/* File size in bytes */
> 
> File size in blocks
> 
> > +struct direct_node {
> > +	__le32 addr[ADDRS_PER_BLOCK];	/* aray of data block address */
> 
> s/aray/array/
> 
> > +} __packed;
> > +
> > +struct indirect_node {
> > +	__le32 nid[NIDS_PER_BLOCK];	/* aray of data block address */
> 
> s/aray/array/

I'll change them.
Thank you.
> 
> Stefan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/