Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378Ab2JJGnJ (ORCPT ); Wed, 10 Oct 2012 02:43:09 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:56311 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956Ab2JJGm6 (ORCPT ); Wed, 10 Oct 2012 02:42:58 -0400 MIME-Version: 1.0 In-Reply-To: <1349796183-30648-3-git-send-email-arnd@arndb.de> References: <1349796183-30648-1-git-send-email-arnd@arndb.de> <1349796183-30648-3-git-send-email-arnd@arndb.de> Date: Wed, 10 Oct 2012 08:42:57 +0200 Message-ID: Subject: Re: [PATCH 2/9] ARM: export set_irq_flags From: Linus Walleij To: Arnd Bergmann Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Magnus Damm , "Rafael J. Wysocki" , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 21 On Tue, Oct 9, 2012 at 5:22 PM, Arnd Bergmann wrote: > The recently added Emma Mobile GPIO driver calls set_irq_flags > and irq_set_chip_and_handler for the interrupts it exports and > it can be built as a module, which currently fails with > > ERROR: "set_irq_flags" [drivers/gpio/gpio-em.ko] undefined! > > We either need to replace the call to set_irq_flags with something > else or export that function. This patch does the latter. Argh! And I cannot think of anything more elegant so Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/