Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060Ab2JJGyq (ORCPT ); Wed, 10 Oct 2012 02:54:46 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:60536 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652Ab2JJGyi (ORCPT ); Wed, 10 Oct 2012 02:54:38 -0400 MIME-Version: 1.0 In-Reply-To: <50698880.1090103@gmail.com> References: <1349076922-25874-1-git-send-email-linus.walleij@stericsson.com> <50698880.1090103@gmail.com> Date: Wed, 10 Oct 2012 08:54:36 +0200 Message-ID: Subject: Re: [PATCH 2/4 v2] irqdomain: augment add_simple() to allocate descs From: Linus Walleij To: Rob Herring , Grant Likely Cc: Linus Walleij , linux-kernel@vger.kernel.org, Thomas Gleixner , Anmar Oueja , Paul Mundt , Russell King , Lee Jones Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1687 Lines: 46 On Mon, Oct 1, 2012 at 2:11 PM, Rob Herring wrote: > On 10/01/2012 02:35 AM, Linus Walleij wrote: >> From: Linus Walleij >> >> Currently we rely on all IRQ chip instances to dynamically >> allocate their IRQ descriptors unless they use the linear >> IRQ domain. So for irqdomain_add_legacy() and >> irqdomain_add_simple() the caller need to make sure that >> descriptors are allocated. >> >> Let's slightly augment the yet unused irqdomain_add_simple() >> to also allocate descriptors as a means to simplify usage >> and avoid code duplication throughout the kernel. >> >> We warn if descriptors cannot be allocated, e.g. if a >> platform has the bad habit of hogging descriptors at boot >> time. >> >> Cc: Rob Herring >> Cc: Thomas Gleixner >> Cc: Grant Likely >> Cc: Paul Mundt >> Cc: Russell King >> Cc: Lee Jones >> Signed-off-by: Linus Walleij > > Looks good. > > Reviewed-by: Rob Herring So what do we do with this patch? Grant? I think the change is good to get in ASAP and since I now have one patch in pinctrl depending on it I have tentatively applied it there. Nobody sent any irqdomain fixes for this merge window, maybe this is the only relevant patch... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/