Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756599Ab2JJN7p (ORCPT ); Wed, 10 Oct 2012 09:59:45 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:65522 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756502Ab2JJN7k (ORCPT ); Wed, 10 Oct 2012 09:59:40 -0400 Date: Wed, 10 Oct 2012 10:00:27 -0400 From: Matt Porter To: Vaibhav Hiremath Cc: linux-omap@vger.kernel.org, Afzal Mohammed , Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode Message-ID: <20121010140027.GB13724@beef> References: <1349773040-8204-1-git-send-email-hvaibhav@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1349773040-8204-1-git-send-email-hvaibhav@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 32 On Tue, Oct 09, 2012 at 02:27:20PM +0530, Vaibhav Hiremath wrote: > With recent changes in omap gpmc driver code, in case of DT > boot mode, where bootloader does not configure gpmc cs space > will result into kernel BUG() inside gpmc_mem_init() function, > as gpmc cs0 gpmc_config7[0].csvalid bit is set to '1' and > gpmc_config7[0].baseaddress is set to '0' on reset. > > This use-case is applicable for any board/EVM which doesn't have > any peripheral connected to gpmc cs0, for example BeagleXM and > BeagleBone, so DT boot mode fails. > > This patch adds of_have_populated_dt() check before creating > device, so that for DT boot mode, gpmc probe will not be called > which is expected behavior, as gpmc is not supported yet from DT. > > Signed-off-by: Vaibhav Hiremath > Cc: Afzal Mohammed > Cc: Tony Lindgren > Cc Paul Walmsley > --- > This should go in for rc1, as this breaks AM33xx boot. Fixes BeagleBone on mainline. Tested-by: Matt Porter -Matt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/