Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292Ab2JJOnS (ORCPT ); Wed, 10 Oct 2012 10:43:18 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:48810 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932204Ab2JJOnR (ORCPT ); Wed, 10 Oct 2012 10:43:17 -0400 MIME-Version: 1.0 In-Reply-To: <20121010134139.GA4005@phenom.dumpdata.com> References: <1349509469-11475-1-git-send-email-yinghai@kernel.org> <1349509469-11475-3-git-send-email-yinghai@kernel.org> <20121009154611.GC7639@phenom.dumpdata.com> <20121010134139.GA4005@phenom.dumpdata.com> Date: Wed, 10 Oct 2012 07:43:15 -0700 X-Google-Sender-Auth: 6d1s6czmPy9XFehT0Ic8KEFYJ-E Message-ID: Subject: Re: [PATCH 2/3] x86, mm: Don't clear page table if next range is ram From: Yinghai Lu To: Konrad Rzeszutek Wilk Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jacob Shin , Tejun Heo , Stefano Stabellini , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 26 On Wed, Oct 10, 2012 at 6:41 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Oct 09, 2012 at 06:00:12PM -0700, Yinghai Lu wrote: >> On Tue, Oct 9, 2012 at 8:46 AM, Konrad Rzeszutek Wilk wrote: >> >> + !e820_any_mapped(addr & PAGE_MASK, next, 0)) >> > >> > What is the 0 parameter for? >> >> any type > > OK, which means that it either should have a #define for it, or at least > a comment, like: > > 0 /* any type */ > > as this would make it clear at first glance what it is - without having > to dive in e820_any_mapped function to determine that. yes, we should add E820_ANY_TYPE. and update e820_any_mapped to use it. will address that later in another patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/