Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755390Ab2JJT1b (ORCPT ); Wed, 10 Oct 2012 15:27:31 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:40159 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093Ab2JJT13 (ORCPT ); Wed, 10 Oct 2012 15:27:29 -0400 Message-ID: <5075CC15.3040809@mvista.com> Date: Wed, 10 Oct 2012 21:27:17 +0200 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121005 Thunderbird/16.0 MIME-Version: 1.0 To: Constantine Shulyupin CC: nsekhar@ti.com, gregkh@linuxfoundation.org, davinci-linux-open-source@linux.davincidsp.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6] Enable USB peripheral mode on dm365 EVM References: <1349872412-22040-1-git-send-email-const@MakeLinux.com> In-Reply-To: <1349872412-22040-1-git-send-email-const@MakeLinux.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3380 Lines: 93 Hello. On 10-10-2012 14:33, Constantine Shulyupin wrote: > From: Constantine Shulyupin > > Sets USB PHY clock source to 24 MHz clock and call USB configuration from board initialization. > > Tested with OTG configuration, usb gadget g_zero on DM365 EVM connected to PC. > > References: > > Definition of USB_PHY_CTRL and PHYCLKFREQ: > - http://www.makelinux.com/lib/ti/DM36x_ARM/doc-141 > > Original patch by miguel.aguilar@ridgerun.com three years ago: > - http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg14741.html > > Signed-off-by: Constantine Shulyupin > --- > > Note: > > Changelog > > Changes since v5 http://www.spinics.net/lists/kernel/msg1413120.html > accordingy feedback of nsekhar@ti.com http://www.spinics.net/lists/kernel/msg1414914.html > - phy configuration moved to drivers/usb/musb/davinci.c > - USB_OTG configuration is submitted in separated patch: http://www.spinics.net/lists/kernel/msg1414964.html > - Setting current limit to 1000 mA. Any way the current is limited to 510 mA in davinci_setup_usb. > > Changes since v4 http://www.spinics.net/lists/kernel/msg1412995.html > - removed fix of dev_info in musb_init_controller > > Changes since v3 http://www.spinics.net/lists/kernel/msg1412544.html: > - removed optional altering of pr_info > > Changes since v1 http://marc.info/?l=linux-kernel&m=130894150803661&w=2: > - removed optional code and reordered > - removed alternation of GPIO33, which is multiplexed with DRVVBUS, because is not need for peripheral USB > > This patch is based on code from projects Arago, Angstom and RidgeRun. > > --- > arch/arm/mach-davinci/board-dm365-evm.c | 2 ++ > drivers/usb/musb/davinci.c | 3 +++ > drivers/usb/musb/davinci.h | 1 + > 3 files changed, 6 insertions(+) > > diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c > index 688a9c5..ba5ffc1 100644 > --- a/arch/arm/mach-davinci/board-dm365-evm.c > +++ b/arch/arm/mach-davinci/board-dm365-evm.c > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include > > #include > > @@ -610,6 +611,7 @@ static __init void dm365_evm_init(void) > > dm365_init_spi0(BIT(0), dm365_evm_spi_info, > ARRAY_SIZE(dm365_evm_spi_info)); > + davinci_setup_usb(1000, 8); > } > > MACHINE_START(DAVINCI_DM365_EVM, "DaVinci DM365 EVM") You need to split the patch at this point. Above part should be applied to the DaVinci tree, below part to the MUSB tree. > diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c > index 472c8b4..af09ebf 100644 > --- a/drivers/usb/musb/davinci.c > +++ b/drivers/usb/musb/davinci.c > @@ -428,6 +428,9 @@ static int davinci_musb_init(struct musb *musb) > __raw_writel(deepsleep, DM355_DEEPSLEEP); > } > > + if (machine_is_davinci_dm365_evm()) > + writel(readl(USB_PHY_CTRL) | USBPHY_CLKFREQ_24MHZ, USB_PHY_CTRL); I'd put that to the board file instead, like in board-da830-evm.c.... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/