Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932525Ab2JJXWD (ORCPT ); Wed, 10 Oct 2012 19:22:03 -0400 Received: from li9-11.members.linode.com ([67.18.176.11]:54908 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669Ab2JJXV6 (ORCPT ); Wed, 10 Oct 2012 19:21:58 -0400 Date: Wed, 10 Oct 2012 19:21:51 -0400 From: "Theodore Ts'o" To: Zach Brown Cc: Kent Overstreet , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH 2/5] aio: kiocb_cancel() Message-ID: <20121010232151.GC11468@thunk.org> Mail-Followup-To: Theodore Ts'o , Zach Brown , Kent Overstreet , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <1349764760-21093-1-git-send-email-koverstreet@google.com> <1349764760-21093-2-git-send-email-koverstreet@google.com> <20121009182625.GM26187@lenny.home.zabbo.net> <20121009213700.GF29494@google.com> <20121010110356.GA11468@thunk.org> <20121010212051.GD6371@lenny.home.zabbo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121010212051.GD6371@lenny.home.zabbo.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 23 On Wed, Oct 10, 2012 at 02:20:51PM -0700, Zach Brown wrote: > > I sympathize, but the reality is that the current infrastructure > is very bad and no one is using it. > > It's not like we're getting rid of the syscall. I'll be behaving > exactly as it does today: returning the error code that indicates that > cancellation failed because it lost the race with completion. Every > caller has to cope with that to use cancel safely. Yes, I realize it doesn't work today. But hopefully we'll be able to reimplement it in a cleaner way. That's why I said, I hope we don't give up on the functionality of aio_cancel --- not that I'm against removing what we currently have. Cheers, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/