Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757498Ab2JJXjZ (ORCPT ); Wed, 10 Oct 2012 19:39:25 -0400 Received: from mga11.intel.com ([192.55.52.93]:29733 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756850Ab2JJXjX convert rfc822-to-8bit (ORCPT ); Wed, 10 Oct 2012 19:39:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,567,1344236400"; d="scan'208";a="232463341" From: "Zheng, Lv" To: Konrad Rzeszutek Wilk CC: "Brown, Len" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jason Wessel , "Tang, Feng" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "x86@kernel.org" , "platform-driver-x86@vger.kernel.org" Subject: RE: [PATCH v6 1/2] ACPI: Add early console framework for DBGP/DBG2. Thread-Topic: [PATCH v6 1/2] ACPI: Add early console framework for DBGP/DBG2. Thread-Index: AQHNppakcK1u0Yu8n0KwBO23isKqApeyDtoAgAEgjyA= Date: Wed, 10 Oct 2012 23:39:19 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E88B9CCEC@SHSMSX101.ccr.corp.intel.com> References: <09ee0e9c79c57da2fc9d0af1c2daeaacdc0bb234.1349838218.git.lv.zheng@intel.com> <20121010141057.GF4005@phenom.dumpdata.com> In-Reply-To: <20121010141057.GF4005@phenom.dumpdata.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1242 Lines: 26 > > +static __initdata DECLARE_BITMAP(acpi_early_flags, > > +MAX_ACPI_DBG_PORTS*2); It's OK since the keep bit will be derived by the real earlycon drivers in the __acpi_early_console_start() which is an arch specific interface. You can find this usage in the [PATCH v6 2/2]. > > + set_bit(port, acpi_early_flags); > > + if (keep) > > + set_bit(port+MAX_ACPI_DBG_PORTS, acpi_early_flags); > Put a comment explaining why you use half of the bitmap to mark them as > 'keep'. Thought wouldn't be just easier if you had another bitmap: > acpi_keep_ports? > To set those instead of using this bitmap? I prefer to put comment here. I've been a deep embedded engineer for the last 5 years, implementing software containing 4 bus protocol stacks within 128bytes ram and 16kbytes rom, where we used high modularity design patterns. Thus made my habit being critical to ram/rom consumption... I'm OOO now, the updated version will be sent next week. Thanks for your comments and best regards/Lv Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/