Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933881Ab2JKCPa (ORCPT ); Wed, 10 Oct 2012 22:15:30 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57330 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964898Ab2JKCPW (ORCPT ); Wed, 10 Oct 2012 22:15:22 -0400 X-Sasl-enc: oTH1EGlqDc3ylncCC2oZew73xQ6sz/jmsH85EMdzpZKg 1349921720 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Greg Kroah-Hartman , alan@lxorguk.ukuu.org.uk, Hayes Wang , Francois Romieu , "David S. Miller" , Jonathan Nieder Subject: [ 65/84] r8169: increase the delay parameter of pm_schedule_suspend Date: Thu, 11 Oct 2012 11:03:49 +0900 Message-Id: <20121011015428.760204781@linuxfoundation.org> X-Mailer: git-send-email 1.8.0.rc0.18.gf84667d In-Reply-To: <20121011015417.017144658@linuxfoundation.org> References: <20121011015417.017144658@linuxfoundation.org> User-Agent: quilt/0.60-2.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1510 Lines: 41 3.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: hayeswang commit 10953db8e1a278742ef7e64a3d1491802bcfa98b upstream The link down would occur when reseting PHY. And it would take about 2 ~ 5 seconds from link down to link up. If the delay of pm_schedule_suspend is not long enough, the device would enter runtime_suspend before link up. After link up, the device would wake up and reset PHY again. Then, you would find the driver keep in a loop of runtime_suspend and rumtime_resume. Signed-off-by: Hayes Wang Acked-by: Francois Romieu Signed-off-by: David S. Miller Reviewed-by: Jonathan Nieder Signed-off-by: Greg Kroah-Hartman --- drivers/net/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1157,7 +1157,7 @@ static void __rtl8169_check_link_status( netif_carrier_off(dev); netif_info(tp, ifdown, dev, "link down\n"); if (pm) - pm_schedule_suspend(&tp->pci_dev->dev, 100); + pm_schedule_suspend(&tp->pci_dev->dev, 5000); } spin_unlock_irqrestore(&tp->lock, flags); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/