Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757241Ab2JKDGa (ORCPT ); Wed, 10 Oct 2012 23:06:30 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:54826 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754586Ab2JKDGN (ORCPT ); Wed, 10 Oct 2012 23:06:13 -0400 Message-ID: <1349924771.2243.16.camel@joe-AO722> Subject: Re: [RFC PATCH 02/06] input/rmi4: Core files From: Joe Perches To: Christopher Heiny Cc: Dmitry Torokhov , Jean Delvare , Linux Kernel , Linux Input , Allie Xiong , Vivian Ly , Daniel Rosenberg , Joerie de Gram , Wolfram Sang , Mathieu Poirier , Linus Walleij , Naveen Kumar Gaddipati , Alexandra Chin Date: Wed, 10 Oct 2012 20:06:11 -0700 In-Reply-To: References: <1349496603-20775-1-git-send-email-cheiny@synaptics.com> <1349496603-20775-3-git-send-email-cheiny@synaptics.com> ,<1349525982.2008.86.camel@joe-AO722> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 32 On Thu, 2012-10-11 at 02:49 +0000, Christopher Heiny wrote: > Joe Perches wrote: [] > > > + list_for_each_entry(entry, &data->rmi_functions.list, list) > > > + if (entry->irq_mask) > > > + process_one_interrupt(entry, irq_status, > > > + data); > > > > style nit, it'd be nicer with braces. > > I agree with you, but checkpatch.pl doesn't. :-( Sure it does. $ cat t.c { list_for_each_entry(entry, &data->rmi_functions.list, list) { if (entry->irq_mask) process_one_interrupt(entry, irq_status, data); } } $ ./scripts/checkpatch.pl --strict -f t.c total: 0 errors, 0 warnings, 0 checks, 7 lines checked t.c has no obvious style problems and is ready for submission. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/