Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754217Ab2JKGow (ORCPT ); Thu, 11 Oct 2012 02:44:52 -0400 Received: from b.relay.invitel.net ([62.77.203.4]:35757 "EHLO b.relay.invitel.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607Ab2JKGou (ORCPT ); Thu, 11 Oct 2012 02:44:50 -0400 X-Greylist: delayed 531 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Oct 2012 02:44:50 EDT Date: Thu, 11 Oct 2012 08:35:47 +0200 From: Heiko Schocher Subject: Re: RE: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc In-reply-to: To: "Manjunathappa, Prakash" Cc: Constantine Shulyupin , "Nori, Sekhar" , "gregkh@linuxfoundation.org" , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Balbi, Felipe" , Sergei Shtylyov , Wolfgang Denk Reply-to: hs@denx.de Message-id: <507668C3.6080908@denx.de> Organization: DENX Software Engineering MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT References: User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120421 Thunderbird/12.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2052 Lines: 63 Hello Manjunathappa On 11.10.2012 07:42, Manjunathappa, Prakash wrote: > Hi, > On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote: >> From: Constantine Shulyupin >> >> Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly >> CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST >> and set MUSB_OTG configuration by default >> because this configuration options are removed from Kconfig. >> >> Signed-off-by: Constantine Shulyupin >> >> --- >> arch/arm/mach-davinci/usb.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/arch/arm/mach-davinci/usb.c b/arch/arm/mach-davinci/usb.c >> index f77b953..34509ff 100644 >> --- a/arch/arm/mach-davinci/usb.c >> +++ b/arch/arm/mach-davinci/usb.c >> @@ -42,14 +42,8 @@ static struct musb_hdrc_config musb_config = { >> }; >> >> static struct musb_hdrc_platform_data usb_data = { >> -#if defined(CONFIG_USB_MUSB_OTG) >> /* OTG requires a Mini-AB connector */ >> .mode = MUSB_OTG, >> -#elif defined(CONFIG_USB_MUSB_PERIPHERAL) >> - .mode = MUSB_PERIPHERAL, >> -#elif defined(CONFIG_USB_MUSB_HOST) >> - .mode = MUSB_HOST, >> -#endif >> .clock = "usb", >> .config =&musb_config, >> }; > > Tested it on DM6446-EVM for host mode with MSC thumb drive and gadget > mode with g-ether. It works. > > Acked-by: Manjunathappa, Prakash I sent a similiar patch here: http://comments.gmane.org/gmane.linux.usb.general/54512 If the issues, mentioned from Sergei for my patch, nullified I add my: Acked-by: Heiko Schocher for this patch. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/