Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758740Ab2JKOKi (ORCPT ); Thu, 11 Oct 2012 10:10:38 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54540 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986Ab2JKOKe (ORCPT ); Thu, 11 Oct 2012 10:10:34 -0400 Message-ID: <5076D354.4040803@canonical.com> Date: Thu, 11 Oct 2012 22:10:28 +0800 From: Jeremy Kerr User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20121003 Thunderbird/15.0.1 MIME-Version: 1.0 To: Andy Whitcroft CC: Matthew Garrett , Matt Fleming , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] efivarfs: efivarfs_fill_super() fix inode reference counts References: <1349416496.810727.310563927016.1.gpush@pecola> <1349951541-20498-1-git-send-email-apw@canonical.com> <1349951541-20498-4-git-send-email-apw@canonical.com> In-Reply-To: <1349951541-20498-4-git-send-email-apw@canonical.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 463 Lines: 19 Hi Andy, > When d_make_root() fails it will automatically drop the reference > on the root inode. We should not be doing so as well. Looks good: Acked-by: Jeremy Kerr Cheers, Jeremy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/