Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758867Ab2JKQ3k (ORCPT ); Thu, 11 Oct 2012 12:29:40 -0400 Received: from mail.servus.at ([193.170.194.20]:45710 "EHLO mail.servus.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758817Ab2JKQ3i (ORCPT ); Thu, 11 Oct 2012 12:29:38 -0400 Message-ID: <5076F3AC.8020304@oberhumer.com> Date: Thu, 11 Oct 2012 18:28:28 +0200 From: "Markus F.X.J. Oberhumer" Organization: oberhumer.com User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.8) Gecko/20121005 Thunderbird/10.0.8 MIME-Version: 1.0 To: Arnd Bergmann CC: Stephen Rothwell , Andrew Morton , linux-kernel@vger.kernel.org, Andi Kleen , Johannes Stezenbach , richard -rw- weinberger , linux-btrfs@vger.kernel.org, linux-crypto@vger.kernel.org, Artem Bityutskiy , Adrian Hunter , David Woodhouse , Phillip Lougher , Dan Magenheimer , Dan Carpenter Subject: Re: [PATCH 0/3] Update LZO compression References: <20121009122614.569b9535.akpm@linux-foundation.org> <50748113.80408@oberhumer.com> <201210111141.27270.arnd@arndb.de> In-Reply-To: <201210111141.27270.arnd@arndb.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2152 Lines: 59 Thanks Arnd, On 2012-10-11 13:41, Arnd Bergmann wrote: > On Tuesday 09 October 2012, Markus F.X.J. Oberhumer wrote: >>> >>> : This commit updates the kernel LZO code to the current upsteam version >>> : which features a significant speed improvement - benchmarking the Calgary >>> : and Silesia test corpora typically shows a doubled performance in >>> : both compression and decompression on modern i386/x86_64/powerpc machines. >>> >>> There are significant clients of the LZO library - crypto, btrfs, >>> jffs2, ubifs, squashfs and zcache. So let's give all those people a cc >>> and ask that they test the LZO changes once they land in linux-next. >>> For correctness and performance, please. >> >> The core compression and decompression code has been thoroughly tested, so I >> do not expect major problems. >> >> Good testing after the merge and feedback about build or performance issues >> (and improvements!) is highly appreciated. > > The addition of the lzo tree to linux-next caused this problem for ARM > imx_v6_v7_defconfig: > > In file included from /home/arnd/linux-arm/arch/arm/boot/compressed/decompress.c:40:0: > /home/arnd/linux-arm/arch/arm/boot/compressed/../../../../lib/decompress_unlzo.c:34:34: fatal error: lzo/lzo1x_decompress.c: No such file or directory > > Since the file was renamed, anything including it needs to be updated to the > new file name. I will add that patch to my tree. Cheers, Markus > > Signed-off-by: Arnd Bergmann > > diff --git a/lib/decompress_unlzo.c b/lib/decompress_unlzo.c > index 4531294..960183d 100644 > --- a/lib/decompress_unlzo.c > +++ b/lib/decompress_unlzo.c > @@ -31,7 +31,7 @@ > */ > > #ifdef STATIC > -#include "lzo/lzo1x_decompress.c" > +#include "lzo/lzo1x_decompress_safe.c" > #else > #include > #endif -- Markus Oberhumer, , http://www.oberhumer.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/