Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758592Ab2JLAG3 (ORCPT ); Thu, 11 Oct 2012 20:06:29 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:58737 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755828Ab2JLAG2 (ORCPT ); Thu, 11 Oct 2012 20:06:28 -0400 MIME-Version: 1.0 In-Reply-To: <20120718092252.GD5006@linux.vnet.ibm.com> References: <20120718092252.GD5006@linux.vnet.ibm.com> Date: Fri, 12 Oct 2012 08:06:28 +0800 Message-ID: Subject: Re: [PATCH] uprobe: fix misleading log entry From: Jovi Zhang To: Andrew Morton Cc: Srikar Dronamraju , Steven Rostedt , =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 46 On Wed, Jul 18, 2012 at 5:22 PM, Srikar Dronamraju wrote: > * Jovi Zhang [2012-07-18 11:08:42]: > >> From 68232ef2decae95b807f2f3763e8ea99c1a3b2ae Mon Sep 17 00:00:00 2001 >> From: Jovi Zhang >> Date: Wed, 18 Jul 2012 17:51:26 +0800 >> Subject: [PATCH] uprobe: fix misleading log entry >> >> There don't have any 'r' prefix in uprobe event naming, remove it. >> >> Signed-off-by: Jovi Zhang >> --- >> kernel/trace/trace_uprobe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c >> index cf382de..852a584 100644 >> --- a/kernel/trace/trace_uprobe.c >> +++ b/kernel/trace/trace_uprobe.c >> @@ -191,7 +191,7 @@ static int create_trace_uprobe(int argc, char **argv) >> if (argv[0][0] == '-') >> is_delete = true; >> else if (argv[0][0] != 'p') { >> - pr_info("Probe definition must be started with 'p', 'r' or" " '-'.\n"); >> + pr_info("Probe definition must be started with 'p' or '-'.\n"); >> return -EINVAL; >> } >> > > Yes, uprobes doesnt support return probes. So we should not have > mentioned about r. > > Acked-by: Srikar Dronamraju > Hi Andrew, Is this patch ok to go through your mm tree? mainline still don't merge it. .jovi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/