Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422724Ab2JLOMz (ORCPT ); Fri, 12 Oct 2012 10:12:55 -0400 Received: from mail-oa0-f46.google.com ([209.85.219.46]:45467 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932762Ab2JLOMy (ORCPT ); Fri, 12 Oct 2012 10:12:54 -0400 MIME-Version: 1.0 In-Reply-To: <20121011204324.12787.30514.stgit@gitlad.jf.intel.com> References: <20121011204324.12787.30514.stgit@gitlad.jf.intel.com> Date: Fri, 12 Oct 2012 10:12:53 -0400 X-Google-Sender-Auth: wMJwrMOcROOMmalDnvtO2r-gKMA Message-ID: Subject: Re: [PATCH v2 0/8] Improve performance of VM translation on x86_64 From: Konrad Rzeszutek Wilk To: Alexander Duyck Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, andi@firstfloor.org, linux-kernel@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3139 Lines: 63 On Thu, Oct 11, 2012 at 4:49 PM, Alexander Duyck wrote: > This patch series is meant to address several issues I encountered with VM > translations on x86_64. In my testing I found that swiotlb was incurring up > to a 5% processing overhead due to calls to __phys_addr. To address that I > have updated swiotlb to use physical addresses instead of virtual addresses > to reduce the need to call __phys_addr. However those patches didn't address > the other callers. With these patches applied I am able to achieve an > additional 1% to 2% performance gain on top of the changes to swiotlb. > > The first 2 patches are the performance optimizations that result in the 1% to > 2% increase in overall performance. The remaining patches are various > cleanups for a number of spots where __pa or virt_to_phys was being called > and was not needed or __pa_symbol could have been used. > Could you also add a blurb in the Documentation/< appropriate file for device driver writes> mentioning the usage of __pa_symbol is preferred? > --- > > Alexander Duyck (8): > x86/lguest: Use __pa_symbol instead of __pa on C visible symbols > x86/acpi: Use __pa_symbol instead of __pa on C visible symbols > x86/xen: Use __pa_symbol instead of __pa on C visible symbols > x86/ftrace: Use __pa_symbol instead of __pa on C visible symbols > x86: Use __pa_symbol instead of __pa on C visible symbols > x86: Drop 4 unnecessary calls to __pa_symbol > x86: Make it so that __pa_symbol can only process kernel symbols on x86_64 > x86: Improve __phys_addr performance by making use of carry flags and inlining > > > arch/x86/include/asm/page.h | 3 ++- > arch/x86/include/asm/page_32.h | 1 + > arch/x86/include/asm/page_64_types.h | 20 +++++++++++++++++-- > arch/x86/kernel/acpi/sleep.c | 2 +- > arch/x86/kernel/cpu/intel.c | 2 +- > arch/x86/kernel/ftrace.c | 4 ++-- > arch/x86/kernel/head32.c | 4 ++-- > arch/x86/kernel/head64.c | 4 ++-- > arch/x86/kernel/setup.c | 16 ++++++++-------- > arch/x86/kernel/x8664_ksyms_64.c | 3 +++ > arch/x86/lguest/boot.c | 3 ++- > arch/x86/mm/pageattr.c | 8 ++++---- > arch/x86/mm/physaddr.c | 35 ++++++++++++++++++++++++++++------ > arch/x86/platform/efi/efi.c | 4 ++-- > arch/x86/realmode/init.c | 8 ++++---- > arch/x86/xen/mmu.c | 19 ++++++++++-------- > 16 files changed, 91 insertions(+), 45 deletions(-) > > -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/