Message-ID: <50784CD3.2040008@kernel.dk>
Date: Fri, 12 Oct 2012 11:01:07 -0600
From: Jens Axboe <axboe@kernel.dk>
MIME-Version: 1.0
To: Derek Basehore <dbasehore@chromium.org>
CC: msb@chromium.org, spang@chromium.org, bfreed@chromium.org,
        arscott@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Remove deadlock in disk_clear_events
References: <1349992327-9747-1-git-send-email-dbasehore@chromium.org>
In-Reply-To: <1349992327-9747-1-git-send-email-dbasehore@chromium.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 820
Lines: 20

On 2012-10-11 15:52, Derek Basehore wrote:
> In disk_clear_events, do not put work on system_nrt_freezable_wq. Instead, put
> it on system_nrt_wq.
> 
> There is a race between probing a usb and suspending the device. Since probing a
> usb calls disk_clear_events, which puts work on a frozen workqueue, probing
> cannot finish after the workqueue is frozen. However, suspending cannot finish
> until the usb probe is finished, so we get a deadlock.

Thanks, applied to later inclusion into 3.7. You did not mark this as
stable, though it seems it should be?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/