Message-ID: <1350067114.2243.35.camel@joe-AO722>
Subject: Re: Spurious warning in checkpatch.pl?
From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Andy Whitcroft <apw@canonical.com>, LKML <linux-kernel@vger.kernel.org>
Date: Fri, 12 Oct 2012 11:38:34 -0700
In-Reply-To: <5078603C.9010709@lwfinger.net>
References: <5078603C.9010709@lwfinger.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 876
Lines: 26

On Fri, 2012-10-12 at 13:23 -0500, Larry Finger wrote:
> Andy,
> 
> The checkpatch.pl version in mainline is issuing what I think are false warnings 
> of the type
> 
> WARNING: networking block comments put the trailing */ on a separate line
> #93: FILE: drivers/net/wireless/rtlwifi/wifi.h:208:
> +       u32 rf_rb;              /* rflssi_readback */
> 
> Is a trailing comment for the member of a struct not allowed?

It's allowed.  Maybe even better, encouraged.

It's a change I made in commit 058806007450
("checkpatch: check networking specific block comment style")
without sufficient testing.

I'll see about fixing it.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/