Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933217Ab2JLS5u (ORCPT ); Fri, 12 Oct 2012 14:57:50 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:46375 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095Ab2JLS5r (ORCPT ); Fri, 12 Oct 2012 14:57:47 -0400 MIME-Version: 1.0 In-Reply-To: <507276A7.8070503@cn.fujitsu.com> References: <506C0AE8.40702@jp.fujitsu.com> <506C0D45.3050909@jp.fujitsu.com> <507276A7.8070503@cn.fujitsu.com> From: KOSAKI Motohiro Date: Fri, 12 Oct 2012 14:57:26 -0400 X-Google-Sender-Auth: vAN7DQm9m9PljKJ0GcSydLec5IM Message-ID: Subject: Re: [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory() To: Wen Congyang Cc: Yasuaki Ishimatsu , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1898 Lines: 46 On Mon, Oct 8, 2012 at 2:45 AM, Wen Congyang wrote: > At 10/05/2012 05:31 AM, KOSAKI Motohiro Wrote: >> On Wed, Oct 3, 2012 at 6:02 AM, Yasuaki Ishimatsu >> wrote: >>> From: Yasuaki Ishimatsu >>> >>> add_memory() hot adds a physical memory. But remove_memory does not >>> hot remove a phsical memory. It only offlines memory. The name >>> confuse us. >>> >>> So the patch renames remove_memory() to offline_memory(). We will >>> use rename_memory() for hot removing memory. >>> >>> CC: David Rientjes >>> CC: Jiang Liu >>> CC: Len Brown >>> CC: Christoph Lameter >>> Cc: Minchan Kim >>> CC: Andrew Morton >>> CC: KOSAKI Motohiro >>> Signed-off-by: Yasuaki Ishimatsu >>> Signed-off-by: Wen Congyang >>> --- >>> drivers/acpi/acpi_memhotplug.c | 2 +- >>> include/linux/memory_hotplug.h | 2 +- >>> mm/memory_hotplug.c | 6 +++--- >>> 3 files changed, 5 insertions(+), 5 deletions(-) >> >> Probably, the better way is to just remove remove_memory() and use >> offline_pages(). > > we don't notify the userspace that the memory is offlined in offline_pages(). > We reimplement offline_memory(), but ishimatsu doesn't include that patch to > this series. Quote from Documentation/SubmittingPatch > 3) Separate your changes. > Separate _logical changes_ into a single patch file. Please send us _logical_ meaningful patch set. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/