Message-ID: <1350072695.7065.71.camel@rhapsody>
Subject: Re: [PATCH 2/5] efivarfs: efivarfs_create() ensure we drop our
 reference on inode on error
From: Khalid Aziz <khalid@gonehiking.org>
To: Matt Fleming <matt.fleming@intel.com>
Cc: Andy Whitcroft <apw@canonical.com>, Matthew Garrett <mjg@redhat.com>,
        Jeremy Kerr <jeremy.kerr@canonical.com>, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 12 Oct 2012 14:11:35 -0600
In-Reply-To: <1350069693.15966.591.camel@mfleming-mobl1.ger.corp.intel.com>
References: <1349416496.810727.310563927016.1.gpush@pecola>
	 <1349951541-20498-1-git-send-email-apw@canonical.com>
	 <1349951541-20498-3-git-send-email-apw@canonical.com>
	 <1350068629.7065.58.camel@rhapsody>
	 <1350069693.15966.591.camel@mfleming-mobl1.ger.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 682
Lines: 17

On Fri, 2012-10-12 at 20:21 +0100, Matt Fleming wrote:
> This is a common idiom used throughout the kernel to simply error paths.
> As you noted, calling kfree(NULL) is harmless and there's certainly no
> need to worry about the overhead of calling kfree() without doing any
> freeing since the error path is also the slow path.

A "return -ENOMEM" looks simpler and easier to read to me, but that is a
subjective opinion :)

--
Khalid

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/