Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660Ab2JLUWR (ORCPT ); Fri, 12 Oct 2012 16:22:17 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:53309 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100Ab2JLUWP (ORCPT ); Fri, 12 Oct 2012 16:22:15 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <1350066620.21172.12996.camel@edumazet-glaptop> References: <1350054908-30646-6-git-send-email-robherring2@gmail.com> <1350065099-32649-1-git-send-email-robherring2@gmail.com> <1350066620.21172.12996.camel@edumazet-glaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] net: calxedaxgmac: rework transmit ring handling From: Rob Herring Date: Fri, 12 Oct 2012 15:21:59 -0500 To: Eric Dumazet CC: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jonathan@jonmasters.org, Mark Langsdorf , Rob Herring , Ben Hutchings Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 36 Eric Dumazet wrote: >On Fri, 2012-10-12 at 13:04 -0500, Rob Herring wrote: >> From: Rob Herring >> >> Only generate tx interrupts on every ring size / 4 descriptors. Move >the >> netif_stop_queue call to the end of the xmit function rather than >> checking at the beginning. >> >> Signed-off-by: Rob Herring >> --- >> v2: >> - Add missed enabling of the descriptor tx interrupt > >Seems to be net-next material to me. > Perhaps, but the series as a whole is what I've been testing. This one has the least performance impact. >Furthermore, your changelog is a bit terse for such a patch, that could >easily break upper layers. > >You need to tell us how long TX completion for a packet might be >deferred. The prior behavior was only interrupting when done with all buffers. It now will interrupt before completely emptying the ring. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/