Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753839Ab2JMQRR (ORCPT ); Sat, 13 Oct 2012 12:17:17 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:58288 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753746Ab2JMQRQ (ORCPT ); Sat, 13 Oct 2012 12:17:16 -0400 Date: Sat, 13 Oct 2012 12:17:06 -0400 From: Christoph Hellwig To: Marco Stornelli Cc: Al Viro , Evgeniy Dushistov , linux-kernel@vger.kernel.org, Linux FS Devel Subject: Re: [PATCH 01/22] ufs: drop vmtruncate Message-ID: <20121013161706.GA19899@infradead.org> References: <506FE786.1030507@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506FE786.1030507@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 17 > @@ -536,8 +536,9 @@ static int ufs_write_begin(struct file *file, struct address_space *mapping, > ufs_getfrag_block); > if (unlikely(ret)) { > loff_t isize = mapping->host->i_size; > - if (pos + len > isize) > - vmtruncate(mapping->host, isize); > + if ((pos + len > isize) && > + inode_newsize_ok(mapping->host, isize) == 0) > + truncate_setsize(mapping->host, isize); write_begin always truncates down, so there should be no call to inode_newsize_ok here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/