Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753881Ab2JMQUV (ORCPT ); Sat, 13 Oct 2012 12:20:21 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:58312 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753764Ab2JMQUS (ORCPT ); Sat, 13 Oct 2012 12:20:18 -0400 Date: Sat, 13 Oct 2012 12:20:15 -0400 From: Christoph Hellwig To: Marco Stornelli Cc: Al Viro , Anton Blanchard , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Linux FS Devel Subject: Re: [PATCH 07/22] adfs: drop vmtruncate Message-ID: <20121013162015.GD19899@infradead.org> References: <506FE958.4070005@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506FE958.4070005@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 700 Lines: 17 > @@ -57,8 +57,9 @@ static int adfs_write_begin(struct file *file, struct address_space *mapping, > &ADFS_I(mapping->host)->mmu_private); > if (unlikely(ret)) { > loff_t isize = mapping->host->i_size; > - if (pos + len > isize) > - vmtruncate(mapping->host, isize); > + if ((pos + len > isize) && > + inode_newsize_ok(mapping->host, isize) == 0) > + truncate_setsize(mapping->host, isize); No need for the inode_newsize_ok check here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/